Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: src/crankshaft/mips/lithium-codegen-mips.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ia32/lithium-ia32.cc ('k') | src/crankshaft/mips/lithium-mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3778 matching lines...) Expand 10 before | Expand all | Expand 10 after
3789 GetRAState(), 3789 GetRAState(),
3790 kSaveFPRegs, 3790 kSaveFPRegs,
3791 EMIT_REMEMBERED_SET, 3791 EMIT_REMEMBERED_SET,
3792 instr->hydrogen()->SmiCheckForWriteBarrier(), 3792 instr->hydrogen()->SmiCheckForWriteBarrier(),
3793 instr->hydrogen()->PointersToHereCheckForValue()); 3793 instr->hydrogen()->PointersToHereCheckForValue());
3794 } 3794 }
3795 } 3795 }
3796 } 3796 }
3797 3797
3798 3798
3799 void LCodeGen::DoStoreNamedGeneric(LStoreNamedGeneric* instr) {
3800 DCHECK(ToRegister(instr->context()).is(cp));
3801 DCHECK(ToRegister(instr->object()).is(StoreDescriptor::ReceiverRegister()));
3802 DCHECK(ToRegister(instr->value()).is(StoreDescriptor::ValueRegister()));
3803
3804 EmitVectorStoreICRegisters<LStoreNamedGeneric>(instr);
3805
3806 __ li(StoreDescriptor::NameRegister(), Operand(instr->name()));
3807 Handle<Code> ic =
3808 CodeFactory::StoreICInOptimizedCode(isolate(), instr->language_mode())
3809 .code();
3810 CallCode(ic, RelocInfo::CODE_TARGET, instr);
3811 }
3812
3813
3814 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) { 3799 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
3815 Condition cc = instr->hydrogen()->allow_equality() ? hi : hs; 3800 Condition cc = instr->hydrogen()->allow_equality() ? hi : hs;
3816 Operand operand(0); 3801 Operand operand(0);
3817 Register reg; 3802 Register reg;
3818 if (instr->index()->IsConstantOperand()) { 3803 if (instr->index()->IsConstantOperand()) {
3819 operand = ToOperand(instr->index()); 3804 operand = ToOperand(instr->index());
3820 reg = ToRegister(instr->length()); 3805 reg = ToRegister(instr->length());
3821 cc = CommuteCondition(cc); 3806 cc = CommuteCondition(cc);
3822 } else { 3807 } else {
3823 reg = ToRegister(instr->index()); 3808 reg = ToRegister(instr->index());
(...skipping 1712 matching lines...) Expand 10 before | Expand all | Expand 10 after
5536 __ lw(result, FieldMemOperand(scratch, 5521 __ lw(result, FieldMemOperand(scratch,
5537 FixedArray::kHeaderSize - kPointerSize)); 5522 FixedArray::kHeaderSize - kPointerSize));
5538 __ bind(deferred->exit()); 5523 __ bind(deferred->exit());
5539 __ bind(&done); 5524 __ bind(&done);
5540 } 5525 }
5541 5526
5542 #undef __ 5527 #undef __
5543 5528
5544 } // namespace internal 5529 } // namespace internal
5545 } // namespace v8 5530 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/ia32/lithium-ia32.cc ('k') | src/crankshaft/mips/lithium-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698