Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: src/crankshaft/arm64/lithium-codegen-arm64.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm64/lithium-arm64.cc ('k') | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h" 5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h"
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5108 matching lines...) Expand 10 before | Expand all | Expand 10 after
5119 ToRegister(instr->temp1()), // Clobbered. 5119 ToRegister(instr->temp1()), // Clobbered.
5120 GetLinkRegisterState(), 5120 GetLinkRegisterState(),
5121 kSaveFPRegs, 5121 kSaveFPRegs,
5122 EMIT_REMEMBERED_SET, 5122 EMIT_REMEMBERED_SET,
5123 instr->hydrogen()->SmiCheckForWriteBarrier(), 5123 instr->hydrogen()->SmiCheckForWriteBarrier(),
5124 instr->hydrogen()->PointersToHereCheckForValue()); 5124 instr->hydrogen()->PointersToHereCheckForValue());
5125 } 5125 }
5126 } 5126 }
5127 5127
5128 5128
5129 void LCodeGen::DoStoreNamedGeneric(LStoreNamedGeneric* instr) {
5130 DCHECK(ToRegister(instr->context()).is(cp));
5131 DCHECK(ToRegister(instr->object()).is(StoreDescriptor::ReceiverRegister()));
5132 DCHECK(ToRegister(instr->value()).is(StoreDescriptor::ValueRegister()));
5133
5134 EmitVectorStoreICRegisters<LStoreNamedGeneric>(instr);
5135
5136 __ Mov(StoreDescriptor::NameRegister(), Operand(instr->name()));
5137 Handle<Code> ic =
5138 CodeFactory::StoreICInOptimizedCode(isolate(), instr->language_mode())
5139 .code();
5140 CallCode(ic, RelocInfo::CODE_TARGET, instr);
5141 }
5142
5143
5144 void LCodeGen::DoStringAdd(LStringAdd* instr) { 5129 void LCodeGen::DoStringAdd(LStringAdd* instr) {
5145 DCHECK(ToRegister(instr->context()).is(cp)); 5130 DCHECK(ToRegister(instr->context()).is(cp));
5146 DCHECK(ToRegister(instr->left()).Is(x1)); 5131 DCHECK(ToRegister(instr->left()).Is(x1));
5147 DCHECK(ToRegister(instr->right()).Is(x0)); 5132 DCHECK(ToRegister(instr->right()).Is(x0));
5148 StringAddStub stub(isolate(), 5133 StringAddStub stub(isolate(),
5149 instr->hydrogen()->flags(), 5134 instr->hydrogen()->flags(),
5150 instr->hydrogen()->pretenure_flag()); 5135 instr->hydrogen()->pretenure_flag());
5151 CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr); 5136 CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);
5152 } 5137 }
5153 5138
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
5694 // Index is equal to negated out of object property index plus 1. 5679 // Index is equal to negated out of object property index plus 1.
5695 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5680 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5696 __ Ldr(result, FieldMemOperand(result, 5681 __ Ldr(result, FieldMemOperand(result,
5697 FixedArray::kHeaderSize - kPointerSize)); 5682 FixedArray::kHeaderSize - kPointerSize));
5698 __ Bind(deferred->exit()); 5683 __ Bind(deferred->exit());
5699 __ Bind(&done); 5684 __ Bind(&done);
5700 } 5685 }
5701 5686
5702 } // namespace internal 5687 } // namespace internal
5703 } // namespace v8 5688 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm64/lithium-arm64.cc ('k') | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698