Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 2358533002: [crankshaft] Remove HStoreNamedGeneric and use HCallWithDescriptor instead to call StoreIC. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-arm.cc ('k') | src/crankshaft/arm64/lithium-arm64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm/lithium-codegen-arm.h" 5 #include "src/crankshaft/arm/lithium-codegen-arm.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/crankshaft/arm/lithium-gap-resolver-arm.h" 10 #include "src/crankshaft/arm/lithium-gap-resolver-arm.h"
(...skipping 3836 matching lines...) Expand 10 before | Expand all | Expand 10 after
3847 GetLinkRegisterState(), 3847 GetLinkRegisterState(),
3848 kSaveFPRegs, 3848 kSaveFPRegs,
3849 EMIT_REMEMBERED_SET, 3849 EMIT_REMEMBERED_SET,
3850 instr->hydrogen()->SmiCheckForWriteBarrier(), 3850 instr->hydrogen()->SmiCheckForWriteBarrier(),
3851 instr->hydrogen()->PointersToHereCheckForValue()); 3851 instr->hydrogen()->PointersToHereCheckForValue());
3852 } 3852 }
3853 } 3853 }
3854 } 3854 }
3855 3855
3856 3856
3857 void LCodeGen::DoStoreNamedGeneric(LStoreNamedGeneric* instr) {
3858 DCHECK(ToRegister(instr->context()).is(cp));
3859 DCHECK(ToRegister(instr->object()).is(StoreDescriptor::ReceiverRegister()));
3860 DCHECK(ToRegister(instr->value()).is(StoreDescriptor::ValueRegister()));
3861
3862 EmitVectorStoreICRegisters<LStoreNamedGeneric>(instr);
3863
3864 __ mov(StoreDescriptor::NameRegister(), Operand(instr->name()));
3865 Handle<Code> ic =
3866 CodeFactory::StoreICInOptimizedCode(isolate(), instr->language_mode())
3867 .code();
3868 CallCode(ic, RelocInfo::CODE_TARGET, instr, NEVER_INLINE_TARGET_ADDRESS);
3869 }
3870
3871
3872 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) { 3857 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
3873 Condition cc = instr->hydrogen()->allow_equality() ? hi : hs; 3858 Condition cc = instr->hydrogen()->allow_equality() ? hi : hs;
3874 if (instr->index()->IsConstantOperand()) { 3859 if (instr->index()->IsConstantOperand()) {
3875 Operand index = ToOperand(instr->index()); 3860 Operand index = ToOperand(instr->index());
3876 Register length = ToRegister(instr->length()); 3861 Register length = ToRegister(instr->length());
3877 __ cmp(length, index); 3862 __ cmp(length, index);
3878 cc = CommuteCondition(cc); 3863 cc = CommuteCondition(cc);
3879 } else { 3864 } else {
3880 Register index = ToRegister(instr->index()); 3865 Register index = ToRegister(instr->index());
3881 Operand length = ToOperand(instr->length()); 3866 Operand length = ToOperand(instr->length());
(...skipping 1641 matching lines...) Expand 10 before | Expand all | Expand 10 after
5523 __ ldr(result, FieldMemOperand(scratch, 5508 __ ldr(result, FieldMemOperand(scratch,
5524 FixedArray::kHeaderSize - kPointerSize)); 5509 FixedArray::kHeaderSize - kPointerSize));
5525 __ bind(deferred->exit()); 5510 __ bind(deferred->exit());
5526 __ bind(&done); 5511 __ bind(&done);
5527 } 5512 }
5528 5513
5529 #undef __ 5514 #undef __
5530 5515
5531 } // namespace internal 5516 } // namespace internal
5532 } // namespace v8 5517 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm/lithium-arm.cc ('k') | src/crankshaft/arm64/lithium-arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698