Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2358513002: [mojo] Initialize MojoCreateSharedBufferOptions struct size. (Closed)

Created:
4 years, 3 months ago by shalamov
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo] Initialize MojoCreateSharedBufferOptions struct size. Initialization of MojoCreateSharedBufferOptions struct size is required to validate flags that are passed in the options parameter. Modifications in this CL are tested by mojo_js_unittests. BUG=606766 Committed: https://crrev.com/009f9ccac2f1205a2634c50ded12c011d5162e70 Cr-Commit-Position: refs/heads/master@{#419781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M mojo/edk/js/core.cc View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
shalamov
Ken, could you please take a look. Thanks.
4 years, 3 months ago (2016-09-20 09:36:20 UTC) #8
Ken Rockot(use gerrit already)
LGTM - thanks!
4 years, 3 months ago (2016-09-20 15:49:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358513002/1
4 years, 3 months ago (2016-09-20 15:59:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 16:05:07 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 16:07:46 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/009f9ccac2f1205a2634c50ded12c011d5162e70
Cr-Commit-Position: refs/heads/master@{#419781}

Powered by Google App Engine
This is Rietveld 408576698