Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2358503002: Change the CompilerDispatcherJob to take a SharedFunctionInfo (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change the CompilerDispatcherJob to take a SharedFunctionInfo This means we can no longer take the closure's context to parse, but need to rely on the outer scope info. Since it's not possible to get that, however, for lazy functions, we introduce a new field to SharedFunctionInfo that stores the outer scope info whenever available. BUG=v8:5215 R=marja@chromium.org,verwaest@chromium.org,jgruber@chromium.org Committed: https://crrev.com/0f0912dd23911eec6d1c5e6d3ebba1ece0ff3361 Cr-Commit-Position: refs/heads/master@{#39548}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 1

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -58 lines) Patch
M src/ast/scopeinfo.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ast/scopes.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/ast/scopes.cc View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M src/compiler.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 2 3 5 chunks +31 lines, -32 lines 0 comments Download
M src/debug/liveedit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +18 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 1 11 chunks +25 lines, -21 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-09-20 08:10:02 UTC) #1
jochen (gone - plz use gerrit)
+hpayer for heap/
4 years, 3 months ago (2016-09-20 09:25:24 UTC) #9
Toon Verwaest
lgtm https://codereview.chromium.org/2358503002/diff/40001/src/compiler-dispatcher/compiler-dispatcher-job.cc File src/compiler-dispatcher/compiler-dispatcher-job.cc (right): https://codereview.chromium.org/2358503002/diff/40001/src/compiler-dispatcher/compiler-dispatcher-job.cc#newcode73 src/compiler-dispatcher/compiler-dispatcher-job.cc:73: parse_info_->set_calls_eval(shared_->scope_info()->CallsEval()); Just drop this line. We'll (re)compute it ...
4 years, 3 months ago (2016-09-20 11:36:15 UTC) #14
Hannes Payer (out of office)
heap lgtm
4 years, 3 months ago (2016-09-20 11:39:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358503002/60001
4 years, 3 months ago (2016-09-20 11:40:46 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-20 12:07:56 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 12:08:54 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0f0912dd23911eec6d1c5e6d3ebba1ece0ff3361
Cr-Commit-Position: refs/heads/master@{#39548}

Powered by Google App Engine
This is Rietveld 408576698