Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2358493002: Remove MTP support on Linux. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, Lei Zhang, tommycli, kinuko+fileapi, nhiroki, tzik, yawano
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MTP support on Linux. It never worked for users anyway since Linux does not have ChromeOS's mtpd. It only worked for me on my Linux workstation to facilitate development because I went through the trouble of building and setting up mtpd. BUG=639863 Committed: https://crrev.com/883b77ef9a872c84caef2356f6df7a8f2f193ee1 Cr-Commit-Position: refs/heads/master@{#421467}

Patch Set 1 #

Patch Set 2 : fix build #

Total comments: 4

Patch Set 3 : move files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -4783 lines) Patch
M chrome/browser/BUILD.gn View 1 2 4 chunks +25 lines, -21 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_object_enumerator.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_object_enumerator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_object_enumerator_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_task_helper.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_task_helper.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_task_helper_map_service.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_device_task_helper_map_service.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_read_file_worker.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/mtp_read_file_worker.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/snapshot_file_details.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/media_galleries/chromeos/snapshot_file_details.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 6 chunks +16 lines, -8 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.h View 1 2 1 chunk +0 lines, -531 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc View 1 2 1 chunk +0 lines, -1899 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_object_enumerator.cc View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_object_enumerator_unittest.cc View 1 2 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_task_helper.h View 1 2 1 chunk +0 lines, -250 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_task_helper.cc View 1 2 1 chunk +0 lines, -399 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_task_helper_map_service.h View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_device_task_helper_map_service.cc View 1 2 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_read_file_worker.h View 1 2 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/media_galleries/linux/mtp_read_file_worker.cc View 1 2 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/media_galleries/linux/snapshot_file_details.h View 1 2 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/media_galleries/linux/snapshot_file_details.cc View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.cc View 6 chunks +13 lines, -5 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
M components/storage_monitor/BUILD.gn View 1 2 6 chunks +20 lines, -15 lines 0 comments Download
A + components/storage_monitor/media_transfer_protocol_device_observer_chromeos.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + components/storage_monitor/media_transfer_protocol_device_observer_chromeos.cc View 9 chunks +25 lines, -25 lines 0 comments Download
A + components/storage_monitor/media_transfer_protocol_device_observer_chromeos_unittest.cc View 5 chunks +26 lines, -25 lines 0 comments Download
D components/storage_monitor/media_transfer_protocol_device_observer_linux.h View 1 chunk +0 lines, -95 lines 0 comments Download
D components/storage_monitor/media_transfer_protocol_device_observer_linux.cc View 1 chunk +0 lines, -252 lines 0 comments Download
D components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M components/storage_monitor/storage_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_chromeos.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_chromeos_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.h View 4 chunks +0 lines, -12 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.cc View 5 chunks +1 line, -34 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux_unittest.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
A + components/storage_monitor/test_media_transfer_protocol_manager_chromeos.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + components/storage_monitor/test_media_transfer_protocol_manager_chromeos.cc View 5 chunks +22 lines, -22 lines 0 comments Download
D components/storage_monitor/test_media_transfer_protocol_manager_linux.h View 1 chunk +0 lines, -72 lines 0 comments Download
D components/storage_monitor/test_media_transfer_protocol_manager_linux.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M components/storage_monitor/test_storage_monitor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/test_storage_monitor.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M device/media_transfer_protocol/BUILD.gn View 4 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
Lei Zhang
4 years, 3 months ago (2016-09-20 09:53:12 UTC) #10
tommycli
lgtm sans nits: https://codereview.chromium.org/2358493002/diff/20001/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/2358493002/diff/20001/chrome/browser/BUILD.gn#newcode2082 chrome/browser/BUILD.gn:2082: sources += [ should we also ...
4 years, 3 months ago (2016-09-20 17:37:46 UTC) #11
Lei Zhang
https://codereview.chromium.org/2358493002/diff/20001/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/2358493002/diff/20001/chrome/browser/BUILD.gn#newcode2082 chrome/browser/BUILD.gn:2082: sources += [ On 2016/09/20 17:37:46, tommycli wrote: > ...
4 years, 2 months ago (2016-09-28 07:23:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358493002/40001
4 years, 2 months ago (2016-09-28 07:23:52 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 07:29:38 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 07:32:10 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/883b77ef9a872c84caef2356f6df7a8f2f193ee1
Cr-Commit-Position: refs/heads/master@{#421467}

Powered by Google App Engine
This is Rietveld 408576698