CSS Motion Path: Use counters for motion properties having effect

CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhRAAAJ
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.

BUG=637543
Committed: https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f
Cr-Commit-Position: refs/heads/master@{#423447}

[Eric Willigers, 2016-09-23 03:36:44]

ericwilligers@chromium.org changed reviewers:
+ timloh@chromium.org

[Eric Willigers, 2016-09-23 03:58:14]

I'll update this CL to include offset-position.

[Eric Willigers, 2016-09-23 04:16:21]

Description was changed from

==========
[WIP] CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhR...
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the offset
shorthand) has a path that is not 'none'. This second use counter will
also be used when offset-position (yet to be implemented) is a position,
and not 'auto'. It will tell us how often the offset* properties have an
effect.

BUG=637543
==========

to

==========
CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhR...
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.

BUG=637543
==========

[Eric Willigers, 2016-09-27 03:18:21]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 03:18:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-09-27 03:18:58]

On 2016/09/23 03:58:14, Eric Willigers wrote:
> I'll update this CL to include offset-position.

Now updated. ptal

[commit-bot: I haz the power, 2016-09-27 03:21:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 03:21:33]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eric Willigers, 2016-09-27 05:37:33]

ericwilligers@chromium.org changed reviewers:
+ suzyh@chromium.org

[Eric Willigers, 2016-09-27 18:53:51]

Patchset #6 (id:100001) has been deleted

[Eric Willigers, 2016-09-27 18:56:23]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:56:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-09-27 18:57:33]

Patchset #2 (id:20001) has been deleted

[Eric Willigers, 2016-09-27 18:57:41]

Patchset #2 (id:40001) has been deleted

[Eric Willigers, 2016-09-27 18:57:55]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-09-27 20:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 20:45:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[suzyh_UTC10 (ex-contributor), 2016-09-28 01:21:28]

lgtm

[Eric Willigers, 2016-09-28 13:57:04]

Patchset #4 (id:140001) has been deleted

[Eric Willigers, 2016-09-28 14:12:49]

Patchset #3 (id:120001) has been deleted

[Eric Willigers, 2016-10-06 01:55:36]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 01:56:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-10-06 02:30:26]

https://codereview.chromium.org/2358433005/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2358433005/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3578: if
(m_context.useCounter() && value && value->isValuePair())
All this logic should move out into separate functions, this large switch
statement intentionally avoids having blocks of logic in it. Also it's somewhat
odd that the consumeOffsetPosition function only has half the logic for
offset-position.

[Eric Willigers, 2016-10-06 03:16:05]

https://codereview.chromium.org/2358433005/diff/180001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2358433005/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3578: if
(m_context.useCounter() && value && value->isValuePair())
On 2016/10/06 02:30:26, Timothy Loh wrote:
> All this logic should move out into separate functions, this large switch
> statement intentionally avoids having blocks of logic in it. Also it's
somewhat
> odd that the consumeOffsetPosition function only has half the logic for
> offset-position.

Done.

[Eric Willigers, 2016-10-06 03:42:21]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 03:42:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-10-06 03:45:27]

On 2016/10/06 03:16:05, Eric Willigers wrote:
>
https://codereview.chromium.org/2358433005/diff/180001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):
> 
>
https://codereview.chromium.org/2358433005/diff/180001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3578: if
> (m_context.useCounter() && value && value->isValuePair())
> On 2016/10/06 02:30:26, Timothy Loh wrote:
> > All this logic should move out into separate functions, this large switch
> > statement intentionally avoids having blocks of logic in it. Also it's
> somewhat
> > odd that the consumeOffsetPosition function only has half the logic for
> > offset-position.
> 
> Done.

lgtm

[commit-bot: I haz the power, 2016-10-06 05:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 05:20:34]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-10-06 06:00:38]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-10-06 06:00:39]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2358433005/#ps220001
(title: "consumeOffsetPath accepts use counter")

[commit-bot: I haz the power, 2016-10-06 06:00:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 06:07:32]

Description was changed from

==========
CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhR...
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.

BUG=637543
==========

to

==========
CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhR...
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.

BUG=637543
==========

[commit-bot: I haz the power, 2016-10-06 06:07:34]

Committed patchset #6 (id:220001)

[commit-bot: I haz the power, 2016-10-06 06:09:10]

Description was changed from

==========
CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhR...
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.

BUG=637543
==========

to

==========
CSS Motion Path: Use counters for motion properties having effect

A use counter was requested in the Intent thread
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/lJTs_LhR...
so we know how often motion-path (and/or the motion shorthand) has a
path that is not 'none'. When the path is none, the motion* properties
have no effect.

We also add a second use counter for when offset-path (and/or the
offset shorthand) has a path that is not 'none', or offset-position is
a position, and not 'auto'. It will tell us how often the offset*
properties have an effect.

BUG=637543

Committed: https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f
Cr-Commit-Position: refs/heads/master@{#423447}
==========

[commit-bot: I haz the power, 2016-10-06 06:09:11]

Patchset 6 (id:??) landed as
https://crrev.com/824859c6bd1aad0b03e1b32dc8f504863b364f9f
Cr-Commit-Position: refs/heads/master@{#423447}