Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2358433004: Cleanup some sRGB TODOs, mostly around setting GrPaint flags correctly (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cleanup some sRGB TODOs, mostly around setting GrPaint flags correctly BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358433004 Committed: https://skia.googlesource.com/skia/+/3e6cf87b5cf48323efbf146e734bbadc7efb5078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M gm/constcolorprocessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkSpecialSurface.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
4 years, 3 months ago (2016-09-20 16:05:01 UTC) #5
bsalomon
lgtm
4 years, 3 months ago (2016-09-20 16:09:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358433004/1
4 years, 3 months ago (2016-09-20 16:55:10 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 16:56:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3e6cf87b5cf48323efbf146e734bbadc7efb5078

Powered by Google App Engine
This is Rietveld 408576698