Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2358433002: Add "threaded scrolling disabled" main thread scrolling reason [spv2] (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
chrishtr, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "threaded scrolling disabled" main thread scrolling reason [spv2] This patch builds on [1] and adds a main thread scrolling reason for when threaded scrolling is disabled. This setting is likely temporary (see: https://crbug.com/410974#c45) but has been implemented for completeness. [1] https://crrev.com/6da0810c8c2362fc73d911750400ccd5c33cd6ca BUG=644514 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/d87b686a8b9e559c1f39d8f5cf445c079773e288 Cr-Commit-Position: refs/heads/master@{#419843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
4 years, 3 months ago (2016-09-20 16:45:40 UTC) #7
chrishtr
lgtm
4 years, 3 months ago (2016-09-20 19:42:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358433002/1
4 years, 3 months ago (2016-09-20 19:42:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 19:48:13 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:50:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d87b686a8b9e559c1f39d8f5cf445c079773e288
Cr-Commit-Position: refs/heads/master@{#419843}

Powered by Google App Engine
This is Rietveld 408576698