Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2358423002: Version 5.5.251.1 (cherry-pick) (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, oth, v8-merges_googlegroups.com, rmcilroy, Paweł Hajdan Jr., ulan
Target Ref:
refs/pending/heads/5.5.251
Project:
v8
Visibility:
Public.

Description

Version 5.5.251.1 (cherry-pick) Merged 5d693348f062ac3e2efc0111d2b4123e6c2d571d Revert of [Interpreter] Optimize BytecodeArrayBuilder and BytecodeArrayWriter. (patchset #6 id:200001 of https://codereview.chromium.org/2351763002/ ) BUG=v8:4280 LOG=N TBR=hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/35cea58f3514228959f635c5d1bfa0207c1e607b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1596 lines, -1324 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 2 chunks +27 lines, -29 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 14 chunks +291 lines, -199 lines 0 comments Download
M src/interpreter/bytecode-array-writer.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-writer.cc View 5 chunks +105 lines, -39 lines 0 comments Download
M src/interpreter/bytecode-dead-code-optimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-dead-code-optimizer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D src/interpreter/bytecode-operands.h View 1 chunk +0 lines, -126 lines 0 comments Download
D src/interpreter/bytecode-operands.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M src/interpreter/bytecode-peephole-optimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-peephole-optimizer.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/interpreter/bytecode-pipeline.h View 5 chunks +21 lines, -144 lines 0 comments Download
M src/interpreter/bytecode-pipeline.cc View 2 chunks +56 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-register-optimizer.h View 3 chunks +12 lines, -9 lines 0 comments Download
M src/interpreter/bytecode-register-optimizer.cc View 8 chunks +40 lines, -33 lines 0 comments Download
M src/interpreter/bytecode-traits.h View 2 chunks +190 lines, -70 lines 0 comments Download
M src/interpreter/bytecodes.h View 8 chunks +232 lines, -359 lines 0 comments Download
M src/interpreter/bytecodes.cc View 10 chunks +466 lines, -74 lines 0 comments Download
M src/v8.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-writer-unittest.cc View 5 chunks +59 lines, -32 lines 0 comments Download
M test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc View 13 chunks +28 lines, -30 lines 0 comments Download
M test/unittests/interpreter/bytecode-pipeline-unittest.cc View 3 chunks +24 lines, -16 lines 0 comments Download
M test/unittests/interpreter/bytecode-register-optimizer-unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/interpreter/bytecodes-unittest.cc View 2 chunks +20 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
4 years, 3 months ago (2016-09-22 06:41:18 UTC) #1
Michael Achenbach
Committed patchset #1 (id:1) manually as 35cea58f3514228959f635c5d1bfa0207c1e607b.
4 years, 3 months ago (2016-09-22 06:43:20 UTC) #3
Michael Hablich
4 years, 3 months ago (2016-09-22 06:55:57 UTC) #4
Message was sent while issue was closed. 
On 2016/09/22 06:43:20, machenbach (slow) wrote:
> Committed patchset #1 (id:1) manually as
> 35cea58f3514228959f635c5d1bfa0207c1e607b.

lgtm

Powered by Google App Engine
This is Rietveld 408576698