Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2358343004: When parsing cookie expiration times, clip out of range dates rather

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org, halliwell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When parsing cookie expiration times, clip out of range dates rather than reject them. Roughly this means cookie expiration times prior to 1970 on POSIX, or after 2038 on 32-bit POSIX, will now be interpreted as either very small or very large base::Time values. BUG=649416

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -18 lines) Patch
M extensions/browser/api/web_request/web_request_api_helpers.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/cookies/canonical_cookie.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/cookies/canonical_cookie.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cookies/cookie_monster_store_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/cookies/cookie_util.h View 1 chunk +7 lines, -2 lines 0 comments Download
M net/cookies/cookie_util.cc View 1 3 chunks +62 lines, -8 lines 0 comments Download
M net/cookies/cookie_util_unittest.cc View 2 chunks +51 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (7 generated)
eroman
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-23 01:42:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358343004/1
4 years, 3 months ago (2016-09-23 01:42:36 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-23 01:55:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358343004/20001
4 years, 3 months ago (2016-09-23 01:56:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-23 02:32:55 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/74224)
4 years, 3 months ago (2016-09-23 02:32:56 UTC) #6
halliwell
4 years, 3 months ago (2016-09-23 13:46:10 UTC) #7
Description was changed from

==========
When parsing cookie expiration times, clip out of range dates rather
than reject them.

Roughly this means cookie expiration times prior to 1970 on POSIX, or
after 2038 on 32-bit POSIX, will now be interpreted as either very small
or very large base::Time values.

BUG=649416
==========

to

==========
When parsing cookie expiration times, clip out of range dates rather
than reject them.

Roughly this means cookie expiration times prior to 1970 on POSIX, or
after 2038 on 32-bit POSIX, will now be interpreted as either very small
or very large base::Time values.

BUG=649416
==========

Powered by Google App Engine
This is Rietveld 408576698