Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2358343002: Simplify memory management for per isolate data (Closed)

Created:
4 years, 3 months ago by Wei Li
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Simplify memory management for per isolate data Use smart pointers for FXJS_PerIsolateData owned member variables. Also move creation and deletion of dynamic object map into FXJS_PerIsolateData's constructor and destructor. Overall, the interfaces and memory management should be simpler. BUG=pdfium:518 Committed: https://pdfium.googlesource.com/pdfium/+/a4ad5957af799374d4710f3847b85f57bea13f47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -26 lines) Patch
M fxjs/fxjs_v8.cpp View 7 chunks +7 lines, -14 lines 0 comments Download
M fxjs/include/fxjs_v8.h View 1 chunk +3 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Wei Li
pls review, thanks
4 years, 3 months ago (2016-09-22 17:29:59 UTC) #6
dsinclair
lgtm
4 years, 3 months ago (2016-09-22 17:38:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358343002/1
4 years, 3 months ago (2016-09-22 17:38:39 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 17:38:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a4ad5957af799374d4710f3847b85f57bea1...

Powered by Google App Engine
This is Rietveld 408576698