Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2358333002: Revert of [heap] Concurrently free empty typed slot set chunks. (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Concurrently free empty typed slot set chunks. (patchset #3 id:40001 of https://codereview.chromium.org/2352423002/ ) Reason for revert: TSAN failures on Linux64: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11850 Also saw various threading-related flakiness on multiple bots. Original issue's description: > [heap] Concurrently free empty typed slot set chunks. > > BUG=chromium:648568 > > Committed: https://crrev.com/ff8101d8e8d5e14dfa89de1252c510e6a0775539 > Cr-Commit-Position: refs/heads/master@{#39605} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Committed: https://crrev.com/c216b7fa83228387e30efd2ee8f4fed81fa38007 Cr-Commit-Position: refs/heads/master@{#39607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -74 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/remembered-set.h View 2 chunks +5 lines, -8 lines 0 comments Download
M src/heap/remembered-set.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/slot-set.h View 6 chunks +1 line, -37 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 1 chunk +16 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
adamk
Created Revert of [heap] Concurrently free empty typed slot set chunks.
4 years, 3 months ago (2016-09-21 23:48:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358333002/1
4 years, 3 months ago (2016-09-21 23:48:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 23:48:50 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 23:49:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c216b7fa83228387e30efd2ee8f4fed81fa38007
Cr-Commit-Position: refs/heads/master@{#39607}

Powered by Google App Engine
This is Rietveld 408576698