Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 235833003: Move helper utilities for the DOM Distiller Viewer to core. (Closed)

Created:
6 years, 8 months ago by nyquist
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move helper utilities for the DOM Distiller Viewer to core. This CL moves the logic for creating HTML content, and retrieving resources from the content/ subfolder of the component to core/. It also provides a helper method for calling the right method on the DomDistillerService based on a URL. BUG=319881 TBR=jochen@chromium.org TBR=jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263511

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebased back to trunk #

Patch Set 4 : Fixed iOS grit whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -237 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M components/dom_distiller/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/content/dom_distiller_viewer_source.h View 2 chunks +2 lines, -8 lines 0 comments Download
M components/dom_distiller/content/dom_distiller_viewer_source.cc View 7 chunks +21 lines, -109 lines 0 comments Download
M components/dom_distiller/content/dom_distiller_viewer_source_unittest.cc View 3 chunks +1 line, -98 lines 0 comments Download
A components/dom_distiller/core/viewer.h View 1 chunk +45 lines, -0 lines 0 comments Download
A components/dom_distiller/core/viewer.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A + components/dom_distiller/core/viewer_unittest.cc View 4 chunks +7 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nyquist
cjhopman: PTAL
6 years, 8 months ago (2014-04-11 21:40:58 UTC) #1
cjhopman
lgtm
6 years, 8 months ago (2014-04-11 21:49:21 UTC) #2
nyquist
jochen: TBR for components/components_tests.gyp jshin: TBR for moving ui/base/l10n DEPS from components/dom_distiller/content to components/dom_distiller/core.
6 years, 8 months ago (2014-04-12 04:00:33 UTC) #3
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 8 months ago (2014-04-12 05:20:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/235833003/40001
6 years, 8 months ago (2014-04-12 05:20:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-12 06:04:10 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, components_unittests, content_unittests, crypto_unittests, net_unittests, ...
6 years, 8 months ago (2014-04-12 06:04:11 UTC) #7
nyquist
The CQ bit was checked by nyquist@chromium.org
6 years, 8 months ago (2014-04-12 06:17:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/235833003/60001
6 years, 8 months ago (2014-04-12 06:17:27 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 10:45:52 UTC) #10
Message was sent while issue was closed.
Change committed as 263511

Powered by Google App Engine
This is Rietveld 408576698