Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 23583052: Handlify JSObject::MigrateInstance and friends. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Handlify JSObject::MigrateInstance and friends. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16899

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments by Toon Verwaest. #

Patch Set 3 : Addressed comment from other CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -58 lines) Patch
M src/hydrogen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 4 chunks +32 lines, -36 lines 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-19 11:04:40 UTC) #1
Toon Verwaest
lgtm with comment https://codereview.chromium.org/23583052/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23583052/diff/1/src/objects.cc#newcode2297 src/objects.cc:2297: // Nothing to do if no ...
7 years, 3 months ago (2013-09-19 11:41:42 UTC) #2
Michael Starzinger
Thanks for the review. Addressed comments. Will land after dependent CL made it in. https://codereview.chromium.org/23583052/diff/1/src/objects.cc ...
7 years, 3 months ago (2013-09-19 15:47:56 UTC) #3
Michael Starzinger
7 years, 3 months ago (2013-09-23 15:02:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r16899 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698