Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 23583040: Added file to verify domain ownership. (Closed)

Created:
7 years, 3 months ago by Andy
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, sethladd
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A chrome/common/extensions/docs/templates/public/google2ed1af765c529f57.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Andy
7 years, 3 months ago (2013-09-06 22:46:22 UTC) #1
sethladd
thanks!
7 years, 3 months ago (2013-09-06 22:46:50 UTC) #2
not at google - send to devlin
lgtm
7 years, 3 months ago (2013-09-06 22:47:18 UTC) #3
Andy
Committed patchset #1 manually as r221805 (presubmit successful).
7 years, 3 months ago (2013-09-06 22:50:22 UTC) #4
please use gerrit instead
The file has executable bit set. This breaks the build (I know, I was also ...
7 years, 3 months ago (2013-09-06 23:29:06 UTC) #5
awatson1
Thanks Rouslan. Sorry about that. Andy On Fri, Sep 6, 2013 at 4:29 PM, <rouslan@chromium.org> ...
7 years, 3 months ago (2013-09-06 23:40:11 UTC) #6
please use gerrit instead
7 years, 3 months ago (2013-09-06 23:42:54 UTC) #7
Message was sent while issue was closed.
On 2013/09/06 23:40:11, awatson1 wrote:
> Thanks Rouslan.  Sorry about that.
> 
> Andy
> 
> 
> On Fri, Sep 6, 2013 at 4:29 PM, <mailto:rouslan@chromium.org> wrote:
> 
> > The file has executable bit set. This breaks the build (I know, I was also
> > surprised.) I will remove the executable bit and dcommit.
> >
> >
>
https://codereview.chromium.**org/23583040/%3Chttps://codereview.chromium.org...>
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I turns out that I cannot dcommit without uploading first. I cannot upload a
patch that has only an exec bit change argh. Going to revert. Please remove the
exec bit ("chmod -x my-file-name" on Linux) and reland.

Powered by Google App Engine
This is Rietveld 408576698