Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 23583039: Convert a bunch of resource IPCs to be control messages. They didn't need to be routed. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
===================================================================
--- content/browser/loader/resource_dispatcher_host_unittest.cc (revision 221543)
+++ content/browser/loader/resource_dispatcher_host_unittest.cc (working copy)
@@ -708,7 +708,7 @@
bool result = PickleIterator(msg).ReadInt(&request_id);
DCHECK(result);
scoped_ptr<IPC::Message> ack(
- new ResourceHostMsg_DataReceived_ACK(msg.routing_id(), request_id));
+ new ResourceHostMsg_DataReceived_ACK(request_id));
base::MessageLoop::current()->PostTask(
FROM_HERE,
@@ -1609,7 +1609,7 @@
EXPECT_TRUE(net::URLRequestTestJob::ProcessOnePendingMessage());
// And now simulate a cancellation coming from the renderer.
- ResourceHostMsg_CancelRequest msg(filter_->child_id(), request_id);
+ ResourceHostMsg_CancelRequest msg(request_id);
bool msg_was_ok;
host_.OnMessageReceived(msg, filter_.get(), &msg_was_ok);
@@ -1644,7 +1644,7 @@
EXPECT_TRUE(net::URLRequestTestJob::ProcessOnePendingMessage());
// And now simulate a cancellation coming from the renderer.
- ResourceHostMsg_CancelRequest msg(filter_->child_id(), request_id);
+ ResourceHostMsg_CancelRequest msg(request_id);
bool msg_was_ok;
host_.OnMessageReceived(msg, filter_.get(), &msg_was_ok);
@@ -1685,7 +1685,7 @@
GURL("http://example.com/blah"));
// And now simulate a cancellation coming from the renderer.
- ResourceHostMsg_CancelRequest msg(filter_->child_id(), request_id);
+ ResourceHostMsg_CancelRequest msg(request_id);
bool msg_was_ok;
host_.OnMessageReceived(msg, filter_.get(), &msg_was_ok);
@@ -1832,7 +1832,7 @@
// Now, simulate the renderer choosing to follow the redirect.
ResourceHostMsg_FollowRedirect redirect_msg(
- new_render_view_id, new_request_id, false, GURL());
+ new_request_id, false, GURL());
host_.OnMessageReceived(redirect_msg, second_filter.get(), &msg_was_ok);
base::MessageLoop::current()->RunUntilIdle();
@@ -1938,7 +1938,7 @@
EXPECT_EQ(ResourceMsg_DataReceived::ID, msgs[0][i].type());
- ResourceHostMsg_DataReceived_ACK msg(0, 1);
+ ResourceHostMsg_DataReceived_ACK msg(1);
bool msg_was_ok;
host_.OnMessageReceived(msg, filter_.get(), &msg_was_ok);
}
@@ -1973,7 +1973,7 @@
// Send some unexpected ACKs.
for (size_t i = 0; i < 128; ++i) {
- ResourceHostMsg_DataReceived_ACK msg(0, 1);
+ ResourceHostMsg_DataReceived_ACK msg(1);
bool msg_was_ok;
host_.OnMessageReceived(msg, filter_.get(), &msg_was_ok);
}
@@ -1992,7 +1992,7 @@
EXPECT_EQ(ResourceMsg_DataReceived::ID, msgs[0][i].type());
- ResourceHostMsg_DataReceived_ACK msg(0, 1);
+ ResourceHostMsg_DataReceived_ACK msg(1);
bool msg_was_ok;
host_.OnMessageReceived(msg, filter_.get(), &msg_was_ok);
}

Powered by Google App Engine
This is Rietveld 408576698