Added hit test for ChromeOS avatar when visible.

Added hit test for ChromeOS avatar when visible.

BUG=282594
TEST=Run ChromeOS with flags:
     --force-fieldtrials="ShowProfileSwitcher/AlwaysShow/"
     --multi-profiles

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221857

[michaelpg, 2013-09-04 20:56:58]

https://codereview.chromium.org/23583037/diff/1/chrome/browser/profiles/avata...
File chrome/browser/profiles/avatar_menu_model.cc (right):

https://codereview.chromium.org/23583037/diff/1/chrome/browser/profiles/avata...
chrome/browser/profiles/avatar_menu_model.cc:281: if
(profiles::IsMultipleProfilesEnabled()) {
Should return false if the profile switcher field trial switch is NOT present.
Still, I'm not sure if this will break any existing tests I'm not aware of.

[James Cook, 2013-09-04 23:25:17]

https://codereview.chromium.org/23583037/diff/1/chrome/browser/profiles/avata...
File chrome/browser/profiles/avatar_menu_model.cc (right):

https://codereview.chromium.org/23583037/diff/1/chrome/browser/profiles/avata...
chrome/browser/profiles/avatar_menu_model.cc:281: if
(profiles::IsMultipleProfilesEnabled()) {
On 2013/09/04 20:56:58, Michael Giuffrida wrote:
> Should return false if the profile switcher field trial switch is NOT present.
> Still, I'm not sure if this will break any existing tests I'm not aware of.

"git cl try" is your friend :-)

https://codereview.chromium.org/23583037/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/23583037/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:162: if
((avatar_button() &&
Consolidate this with the if() above

[michaelpg, 2013-09-05 02:42:45]

https://codereview.chromium.org/23583037/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/23583037/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:162: if
((avatar_button() &&
Ok, how's this? Seems to be the least ugly way to do it.

[James Cook, 2013-09-05 15:15:16]

lgtm with an optional suggestion

https://codereview.chromium.org/23583037/diff/2004/chrome/browser/ui/views/fr...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/23583037/diff/2004/chrome/browser/ui/views/fr...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:161: if
(hit_test == HTCAPTION && ((avatar_button() &&
This is fine. Now that I think about it another way to do it would be to create:

bool HitAvatarButton(const gfx::Point& point) {
  if (avatar_button() && ...)
    return true;
  if (avatar_label() && ...)
    return true;
  return false;
}

[commit-bot: I haz the power, 2013-09-05 23:15:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelpg@chromium.org/23583037/2004

[commit-bot: I haz the power, 2013-09-05 23:32:45]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[michaelpg, 2013-09-06 04:19:11]

Could I get a review from one of the profiles owners? Thanks!

[Elliot Glaysher, 2013-09-06 18:14:08]

profiles lgtm

[commit-bot: I haz the power, 2013-09-06 20:44:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelpg@chromium.org/23583037/2004

[commit-bot: I haz the power, 2013-09-06 21:46:40]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-07 00:29:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelpg@chromium.org/23583037/2004

[commit-bot: I haz the power, 2013-09-07 01:58:04]

Change committed as 221857