Check if timeout has expired after processing each sample

Check if timeout has expired after processing each sample

To avoid long intervals between taking samples due to processing all accumulated samples at once, the samples are processed one by one and we check if the sampling interval has elapsed after each step rather than after processing all the samples in the queue.

BUG=v8:2814
R=bmeurer@chromium.org, loislo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16548

[loislo, 2013-09-04 14:35:36]

lgtm with nits

https://codereview.chromium.org/23583036/diff/3001/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):

https://codereview.chromium.org/23583036/diff/3001/src/cpu-profiler.cc#newcod...
src/cpu-profiler.cc:117: const TickSampleEventRecord* record =
ticks_buffer_.StartDequeue();
please rename StartDequeue to peek and FinishDequeue to remove as like as in
java queue interface.

[loislo, 2013-09-04 14:35:46]

On 2013/09/04 14:35:36, loislo wrote:
> lgtm with nits
> 
> https://codereview.chromium.org/23583036/diff/3001/src/cpu-profiler.cc
> File src/cpu-profiler.cc (right):
> 
>
https://codereview.chromium.org/23583036/diff/3001/src/cpu-profiler.cc#newcod...
> src/cpu-profiler.cc:117: const TickSampleEventRecord* record =
> ticks_buffer_.StartDequeue();
> please rename StartDequeue to peek and FinishDequeue to remove as like as in
> java queue interface.

in a separate patch

[yurys, 2013-09-04 14:41:53]

On 2013/09/04 14:35:46, loislo wrote:
> On 2013/09/04 14:35:36, loislo wrote:
> > lgtm with nits
> > 
> > https://codereview.chromium.org/23583036/diff/3001/src/cpu-profiler.cc
> > File src/cpu-profiler.cc (right):
> > 
> >
>
https://codereview.chromium.org/23583036/diff/3001/src/cpu-profiler.cc#newcod...
> > src/cpu-profiler.cc:117: const TickSampleEventRecord* record =
> > ticks_buffer_.StartDequeue();
> > please rename StartDequeue to peek and FinishDequeue to remove as like as in
> > java queue interface.
> 
> in a separate patch

Done. See https://codereview.chromium.org/23686006/

[Benedikt Meurer, 2013-09-05 07:33:09]

LGTM.

[yurys, 2013-09-05 10:29:08]

Committed patchset #2 manually as r16548 (presubmit successful).