DevTools FE uploader: create checker instance to validate uploads

DevTools FE uploader: create checker instance to validate uploads

Runs on a separate GCE instance from the uploader and periodically checks
that earlier commits have been uploaded to the devtools frontend appspot instance.

This runs a simple HTTP server in a separate daemon thread so GCP/Stackdriver
can do a periodic uptime check. Ideally, because the HTTP server and checker thread
run in the same process, they should have similar uptime.

BUG=none
R=dgozman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=11c855a5fad1efc09c0526c19c9e7b0f11531146

[chenwilliam, 2016-09-21 23:59:44]

Patchset #2 (id:20001) has been deleted

[chenwilliam, 2016-09-22 00:12:31]

Description was changed from

==========
DevTools FE uploader: create checker instance to validate uploads

Runs on a separate GCE instance from the uploader and periodically checks
that earlier commits have been uploaded to the devtools frontend appspot
instance.

BUG=none
==========

to

==========
DevTools FE uploader: create checker instance to validate uploads

Runs on a separate GCE instance from the uploader and periodically checks
that earlier commits have been uploaded to the devtools frontend appspot
instance.

This runs a simple HTTP server in a separate daemon thread so GCP/Stackdriver
can do a periodic uptime check. Ideally, because the HTTP server and checker
thread
run in the same process, they should have similar uptime.

BUG=none
==========

[chenwilliam, 2016-09-22 00:18:30]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2016-09-22 00:18:30]

PTAL. I will update our internal clank docs with instructions on how to setup
and run the checker.

[dgozman, 2016-09-22 16:42:54]

lgtm

https://codereview.chromium.org/2358303002/diff/40001/gce/checker.py
File gce/checker.py (right):

https://codereview.chromium.org/2358303002/diff/40001/gce/checker.py#newcode63
gce/checker.py:63: global consecutive_success
Why this? Ain't consecutive_success already visible?

https://codereview.chromium.org/2358303002/diff/40001/gce/start_checker.sh
File gce/start_checker.sh (right):

https://codereview.chromium.org/2358303002/diff/40001/gce/start_checker.sh#ne...
gce/start_checker.sh:2: # Copyright (c) 2016 The Chromium Authors. All rights
reserved.
No (c) in copyrights

[chenwilliam, 2016-09-22 20:25:53]

https://codereview.chromium.org/2358303002/diff/40001/gce/checker.py
File gce/checker.py (right):

https://codereview.chromium.org/2358303002/diff/40001/gce/checker.py#newcode63
gce/checker.py:63: global consecutive_success
On 2016/09/22 at 16:42:54, dgozman wrote:
> Why this? Ain't consecutive_success already visible?

It's visible but consecutive_success += 1 causes the error "UnboundLocalError:
local variable referenced before assignment"

This happens because when you assign a value to a variable, python automatically
treats it as a local variable.

https://codereview.chromium.org/2358303002/diff/40001/gce/start_checker.sh
File gce/start_checker.sh (right):

https://codereview.chromium.org/2358303002/diff/40001/gce/start_checker.sh#ne...
gce/start_checker.sh:2: # Copyright (c) 2016 The Chromium Authors. All rights
reserved.
On 2016/09/22 16:42:54, dgozman wrote:
> No (c) in copyrights

Done.

[chenwilliam, 2016-09-23 00:59:09]

Added a patchset that fixes the email logic (I made a mistake so it sent two
consecutive emails 30 minutes apart).

[dgozman, 2016-09-23 01:07:28]

still lgtm

[chenwilliam, 2016-09-23 22:28:48]

Description was changed from

==========
DevTools FE uploader: create checker instance to validate uploads

Runs on a separate GCE instance from the uploader and periodically checks
that earlier commits have been uploaded to the devtools frontend appspot
instance.

This runs a simple HTTP server in a separate daemon thread so GCP/Stackdriver
can do a periodic uptime check. Ideally, because the HTTP server and checker
thread
run in the same process, they should have similar uptime.

BUG=none
==========

to

==========
DevTools FE uploader: create checker instance to validate uploads

Runs on a separate GCE instance from the uploader and periodically checks
that earlier commits have been uploaded to the devtools frontend appspot
instance.

This runs a simple HTTP server in a separate daemon thread so GCP/Stackdriver
can do a periodic uptime check. Ideally, because the HTTP server and checker
thread
run in the same process, they should have similar uptime.

BUG=none
R=dgozman@chromium.org

Committed:
https://src.chromium.org/viewvc/chrome?view=rev&revision=11c855a5fad1efc09c05...
==========

[chenwilliam, 2016-09-23 22:28:49]

Committed patchset #4 (id:80001) manually as
11c855a5fad1efc09c0526c19c9e7b0f11531146 (presubmit successful).