Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chromeos/network/network_connection_handler.cc

Issue 23583018: Check configuration for networks without UIData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Always return 'false' for VPN in IsCertificateConfigured. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_connection_handler.cc
diff --git a/chromeos/network/network_connection_handler.cc b/chromeos/network/network_connection_handler.cc
index 8a239f00709fb589bbd55dd8f309e268660af877..f1805b4faac4547925b8c424ae8d282e9bad50ba 100644
--- a/chromeos/network/network_connection_handler.cc
+++ b/chromeos/network/network_connection_handler.cc
@@ -439,6 +439,12 @@ void NetworkConnectionHandler::VerifyConfiguredAndConnect(
ErrorCallbackForPendingRequest(service_path, kErrorCertificateRequired);
return;
}
+ } else if (check_error_state &&
+ !client_cert::IsCertificateConfigured(client_cert_type,
+ service_properties)) {
+ // Network may not be configured.
+ ErrorCallbackForPendingRequest(service_path, kErrorConfigurationRequired);
+ return;
}
// The network may not be 'Connectable' because the TPM properties are not
« chromeos/network/client_cert_util.cc ('K') | « chromeos/network/client_cert_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698