Check configuration for networks without UIData

chromeos/network/network_connection_handler.cc

Index: chromeos/network/network_connection_handler.cc
diff --git a/chromeos/network/network_connection_handler.cc b/chromeos/network/network_connection_handler.cc
index 151d8f64d5608cea117da3d4ff5abf7cadf47df2..e664a6af3397ce6be9f354986eb44b8313d773ec 100644
--- a/chromeos/network/network_connection_handler.cc
+++ b/chromeos/network/network_connection_handler.cc
@@ -451,6 +451,13 @@ void NetworkConnectionHandler::VerifyConfiguredAndConnect(
         ErrorCallbackForPendingRequest(service_path, kErrorCertificateRequired);
         return;
       }
+    } else {

[pneubeck (no reviews), 2013/08/31 05:31:30]

NIT: 'else if' and comment inside the clause.

[stevenjb, 2013/09/03 22:33:05]

Done.

[pneubeck (no reviews), 2013/09/04 08:40:00]

See my new comments above. I think, in this branch we don't know that a client
certificate is required.
Without having information from the server it might not be possible what
configuration is required.

However, there might be some other properties that strictly require a client
cert (e.g. maybe some specific EAP authentication method).

Maybe it's correct to require (client_cert || username)
But in case of OpenVPN it at least possible, I think, to not even require that.

[stevenjb, 2013/09/04 17:58:13]

So it sounds like for OpenVPN we never really know whether or not it is
configured, so IsCertificateConfigured() needs to always return false for
OpenVPN; I'll go ahead and change that and add a comment.

+      // Certificate is not configured in ui_data, check properties.
+      if (!client_cert::IsCertificateConfigured(
+              client_cert_type, service_properties)) {
+        ErrorCallbackForPendingRequest(service_path, kErrorCertificateRequired);
+        return;
+      }
     }
 
     // The network may not be 'Connectable' because the TPM properties are not