Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 23583012: Move xxd.pl script to core/scripts as its used by other core components like XMLTreeViewer (Closed)

Created:
7 years, 3 months ago by vivekg_samsung
Modified:
7 years, 3 months ago
Reviewers:
pfeldman, vivekg__
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move xxd.pl script to core/scripts as its used by other core components like XMLTreeViewer xxd.pl is used outside the inspector specifically by the core/xml/parser/XMLDocumentParser and XMLTreeViewer. Hence moving it to core/scripts for generic usage if required. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157141

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -49 lines) Patch
M Source/core/ConvertFileToHeaderWithCharacterArray.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/core_derived_sources.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
D Source/core/inspector/xxd.pl View 1 chunk +0 lines, -45 lines 0 comments Download
A + Source/core/scripts/xxd.pl View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vivekg__
PTAL, thanks!
7 years, 3 months ago (2013-08-29 11:11:37 UTC) #1
pfeldman
https://codereview.chromium.org/23583012/diff/1/LayoutTests/inspector/resources/blink-fs.js File LayoutTests/inspector/resources/blink-fs.js (left): https://codereview.chromium.org/23583012/diff/1/LayoutTests/inspector/resources/blink-fs.js#oldcode163 LayoutTests/inspector/resources/blink-fs.js:163: "./Source/core/inspector/xxd.pl", This is just a test data, no need ...
7 years, 3 months ago (2013-08-29 11:21:35 UTC) #2
vivekg_samsung
On 2013/08/29 11:21:35, pfeldman wrote: > https://codereview.chromium.org/23583012/diff/1/LayoutTests/inspector/resources/blink-fs.js > File LayoutTests/inspector/resources/blink-fs.js (left): > > https://codereview.chromium.org/23583012/diff/1/LayoutTests/inspector/resources/blink-fs.js#oldcode163 > ...
7 years, 3 months ago (2013-08-29 11:46:48 UTC) #3
pfeldman
I'd just revert that part to not confuse people that will see this change associated ...
7 years, 3 months ago (2013-08-29 12:03:45 UTC) #4
vivekg__
On 2013/08/29 12:03:45, pfeldman wrote: > I'd just revert that part to not confuse people ...
7 years, 3 months ago (2013-08-29 12:12:50 UTC) #5
vivekg__
On 2013/08/29 12:12:50, vivekg_ wrote: > On 2013/08/29 12:03:45, pfeldman wrote: > > I'd just ...
7 years, 3 months ago (2013-09-02 07:25:24 UTC) #6
pfeldman
lgtm
7 years, 3 months ago (2013-09-03 16:14:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23583012/7001
7 years, 3 months ago (2013-09-03 16:24:51 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 18:04:35 UTC) #9
Message was sent while issue was closed.
Change committed as 157141

Powered by Google App Engine
This is Rietveld 408576698