[builtins] migrate C++ String Iterator builtins to baseline TurboFan

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/ieee754.h"
 #include "src/code-stubs.h"
@@ skipping 1422 matching lines @@
 
     Handle<JSObject> string_iterator_prototype =
         factory->NewJSObject(isolate->object_function(), TENURED);
     JSObject::ForceSetPrototype(string_iterator_prototype, iterator_prototype);
 
     JSObject::AddProperty(
         string_iterator_prototype, factory->to_string_tag_symbol(),
         factory->NewStringFromAsciiChecked("String Iterator"),
         static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY));
 
-    InstallFunction(string_iterator_prototype, "next", JS_OBJECT_TYPE,
-                    JSObject::kHeaderSize, MaybeHandle<JSObject>(),
-                    Builtins::kStringIteratorPrototypeNext);
+    Handle<JSFunction> next =
+        InstallFunction(string_iterator_prototype, "next", JS_OBJECT_TYPE,
+                        JSObject::kHeaderSize, MaybeHandle<JSObject>(),
+                        Builtins::kStringIteratorPrototypeNext);
+
+    // Set the expected parameters for %StringIteratorPrototype%.next to 1;
+    // required by builtin.
+    next->shared()->set_internal_formal_parameter_count(0);

[Benedikt Meurer, 2016/09/26 18:38:22]

Comment says 1, but code says 0?

Also why not SimpleInstallFunction(string_iterator_prototype, "next",
Builtins::kStringIteratorPrototypeNext, 0, true) here?

[caitp, 2016/09/27 08:55:56]

AFAIK this intensionally does not include receiver (based on other callers in
this file not including the receiver).

[Benedikt Meurer, 2016/09/27 08:58:54]

Yes, but then the comment should say that it takes 0 parameters (not including
the receiver) :-)

[caitp, 2016/09/27 09:14:18]

Done.

+
+    // Set the length for the function to satisfy ECMA-262.
+    next->shared()->set_length(0);
 
     Handle<JSFunction> string_iterator_function = CreateFunction(
         isolate, factory->NewStringFromAsciiChecked("StringIterator"),
         JS_STRING_ITERATOR_TYPE, JSStringIterator::kSize,
         string_iterator_prototype, Builtins::kIllegal);
     native_context()->set_string_iterator_map(
         string_iterator_function->initial_map());
   }
 
   {
@@ skipping 2729 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8