Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2358243002: Use unique_ptr<CPDF_Object, ReleaseDeleter<>> in more places (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use unique_ptr<CPDF_Object, ReleaseDeleter<>> in more places Committed: https://pdfium.googlesource.com/pdfium/+/298880f334ff1b8a1f3414d8ea8c2103e7755300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 5 chunks +6 lines, -9 lines 0 comments Download
M core/fpdfapi/fpdf_edit/include/cpdf_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-21 20:46:51 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-09-21 20:48:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358243002/1
4 years, 3 months ago (2016-09-21 21:04:10 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 21:04:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/298880f334ff1b8a1f3414d8ea8c2103e775...

Powered by Google App Engine
This is Rietveld 408576698