Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: components/metrics/metrics_pref_names.cc

Issue 2358223002: Add log date to the metrics log (Closed)
Patch Set: Adding log date in persisted logs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_pref_names.cc
diff --git a/components/metrics/metrics_pref_names.cc b/components/metrics/metrics_pref_names.cc
index fb32cd9ae713cb756f91656f7682373e8caca4fc..8035368c5493c9a1b391b784fc7bfe3d1abc0880 100644
--- a/components/metrics/metrics_pref_names.cc
+++ b/components/metrics/metrics_pref_names.cc
@@ -7,6 +7,19 @@
namespace metrics {
namespace prefs {
+// Array of strings that are each UMA logs that were supposed to be sent in the
+// first minute of a browser session. These logs include things like crash count
+// info, etc.
+const char kDeprecatedMetricsInitialLogs[] =
+ "user_experience_metrics.initial_logs_list";
+
+// Array of strings that are each UMA logs that were not sent because the
+// browser terminated before these accumulated metrics could be sent. These
+// logs typically include histograms and memory reports, as well as ongoing
+// user activities.
+const char kDeprecatedMetricsOngoingLogs[] =
+ "user_experience_metrics.ongoing_logs_list";
+
// Set once, to the current epoch time, on the first run of chrome on this
// machine. Attached to metrics reports forever thereafter.
const char kInstallDate[] = "uninstall_metrics.installation_date2";
@@ -27,7 +40,7 @@ const char kMetricsDefaultOptIn[] = "user_experience_metrics.default_opt_in";
// first minute of a browser session. These logs include things like crash count
// info, etc.
Alexei Svitkine (slow) 2016/09/28 18:50:30 Update comment here and below.
gayane -on leave until 09-2017 2016/09/28 20:50:49 Done.
const char kMetricsInitialLogs[] =
- "user_experience_metrics.initial_logs_list";
+ "user_experience_metrics.initial_logs_dict_list";
Alexei Svitkine (slow) 2016/09/28 18:50:30 I would just name it "initial_logs2" and "ongoing_
gayane -on leave until 09-2017 2016/09/28 20:50:49 Done.
// The metrics entropy source.
// Note: The name low_entropy_source2 is a result of creating
@@ -44,7 +57,7 @@ const char kMetricsMachineId[] = "user_experience_metrics.machine_id";
// logs typically include histograms and memory reports, as well as ongoing
// user activities.
const char kMetricsOngoingLogs[] =
- "user_experience_metrics.ongoing_logs_list";
+ "user_experience_metrics.ongoing_logs_dict_list";
// Boolean that indicates a cloned install has been detected and the metrics
// client id and low entropy source should be reset.

Powered by Google App Engine
This is Rietveld 408576698