Include referenced declared variables and their values into the linked bundle hash.

Include referenced declared variables and their values into the linked bundle hash.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/33250044614b61e57ea461f77cf0f1888a182c20

[Paul Berry, 2016-09-21 19:47:22]

lgtm

https://codereview.chromium.org/2358213002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/pub_summary.dart (right):

https://codereview.chromium.org/2358213002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/pub_summary.dart:756: for (String name in names) {
Before the for loop, add:

signature.addInt(names.length);

(Otherwise there's a small risk of hash collisions).

Also, can we sort the names before adding them to the signature?  That would
reduce the risk of an unnecessary mismatch if the set iteration order changes.

[Brian Wilkerson, 2016-09-21 20:00:11]

lgtm

[scheglov, 2016-09-21 20:34:49]

https://codereview.chromium.org/2358213002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/pub_summary.dart (right):

https://codereview.chromium.org/2358213002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/pub_summary.dart:756: for (String name in names) {
On 2016/09/21 19:47:22, Paul Berry wrote:
> Before the for loop, add:
> 
> signature.addInt(names.length);
> 
> (Otherwise there's a small risk of hash collisions).
> 
> Also, can we sort the names before adding them to the signature?  That would
> reduce the risk of an unnecessary mismatch if the set iteration order changes.

Done.

[scheglov, 2016-09-21 20:35:04]

Description was changed from

==========
Include referenced declared variables and their values into the linked bundle
hash.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Include referenced declared variables and their values into the linked bundle
hash.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/33250044614b61e57ea461f77cf0f1888a182c20
==========

[scheglov, 2016-09-21 20:35:05]

Committed patchset #2 (id:20001) manually as
33250044614b61e57ea461f77cf0f1888a182c20 (presubmit successful).