CSS Properties and Values API: Use initial value where appropriate for var()

CSS Properties and Values API: Use initial value where appropriate for var()

This patch fixes var() references to registered properties to return
initial values where appropriate. When a registered property is not
explicitly set, var() references to it should result in that property's
initial value. We now store the initial value as a token stream as well
to accommodate this.

Any unregistered property in a var() cycle will continue to compute to
their initial value (i.e. the invalid value). Any registered property
in a var() cycle similar compute to their initial value (I don't think
this is explicitly mentioned in the spec, but for consistency this makes
more sense than the unset value). Valid references to properties in a
var() cycle will resolve to the referenced property'd initial value.

BUG=641877
Committed: https://crrev.com/a44ebf4ccff547bda5de22979e93ac65c3b2b93c
Cr-Commit-Position: refs/heads/master@{#420579}

[Timothy Loh, 2016-09-22 09:51:30]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 09:51:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-09-22 10:01:24]

timloh@chromium.org changed reviewers:
+ meade@chromium.org

[Timothy Loh, 2016-09-22 10:01:25]

https://codereview.chromium.org/2358203003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
(right):

https://codereview.chromium.org/2358203003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp:67: return
registration->initialVariableData();
We could alternatively set the initial values into the maps instead of nullptr
(which already means initial values). I don't think there's much difference so I
left it as setting nullptr.

[meade_UTC10, 2016-09-23 01:16:50]

lgtm

https://codereview.chromium.org/2358203003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
(right):

https://codereview.chromium.org/2358203003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp:67: return
registration->initialVariableData();
On 2016/09/22 10:01:25, Timothy Loh wrote:
> We could alternatively set the initial values into the maps instead of nullptr
> (which already means initial values). I don't think there's much difference so
I
> left it as setting nullptr.

seems fine as is.

[Timothy Loh, 2016-09-23 03:42:35]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:42:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 05:05:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 05:07:24]

Description was changed from

==========
CSS Properties and Values API: Use initial value where appropriate for var()

This patch fixes var() references to registered properties to return
initial values where appropriate. When a registered property is not
explicitly set, var() references to it should result in that property's
initial value. We now store the initial value as a token stream as well
to accommodate this.

Any unregistered property in a var() cycle will continue to compute to
their initial value (i.e. the invalid value). Any registered property
in a var() cycle similar compute to their initial value (I don't think
this is explicitly mentioned in the spec, but for consistency this makes
more sense than the unset value). Valid references to properties in a
var() cycle will resolve to the referenced property'd initial value.

BUG=641877
==========

to

==========
CSS Properties and Values API: Use initial value where appropriate for var()

This patch fixes var() references to registered properties to return
initial values where appropriate. When a registered property is not
explicitly set, var() references to it should result in that property's
initial value. We now store the initial value as a token stream as well
to accommodate this.

Any unregistered property in a var() cycle will continue to compute to
their initial value (i.e. the invalid value). Any registered property
in a var() cycle similar compute to their initial value (I don't think
this is explicitly mentioned in the spec, but for consistency this makes
more sense than the unset value). Valid references to properties in a
var() cycle will resolve to the referenced property'd initial value.

BUG=641877

Committed: https://crrev.com/a44ebf4ccff547bda5de22979e93ac65c3b2b93c
Cr-Commit-Position: refs/heads/master@{#420579}
==========

[commit-bot: I haz the power, 2016-09-23 05:07:25]

Patchset 3 (id:??) landed as
https://crrev.com/a44ebf4ccff547bda5de22979e93ac65c3b2b93c
Cr-Commit-Position: refs/heads/master@{#420579}