Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2070)

Issue 2358193002: Revert of Disallow navigations to blob URLs with non-canonical origins. (Closed)

Created:
4 years, 3 months ago by dewittj
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disallow navigations to blob URLs with non-canonical origins. (patchset #4 id:60001 of https://codereview.chromium.org/2347163004/ ) Reason for revert: Likely breaks this layout test: http/tests/xmlhttprequest/xhr-to-blob-in-isolated-world.html e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux --- /mnt/data/b/rr/tmpVD1Qdr/w/layout-test-results/http/tests/xmlhttprequest/xhr-to-blob-in-isolated-world-expected.txt +++ /mnt/data/b/rr/tmpVD1Qdr/w/layout-test-results/http/tests/xmlhttprequest/xhr-to-blob-in-isolated-world-actual.txt @@ -1,3 +1,4 @@ CONSOLE WARNING: line 1: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/. +CONSOLE ERROR: line 1: Uncaught NetworkError: Failed to execute 'send' on 'XMLHttpRequest': Failed to load 'blob:chrome-extension://123/456789'. This tests an isolated script's ability to XHR a blob that is in its security origin, which is not the same as the document's security origin. We pass if there are no console errors. Original issue's description: > Disallow navigations to blob URLs with non-canonical origins. > > BUG=646278 > TEST=content_browsertests, included > > Committed: https://crrev.com/654b9b9e4b7bdec1366e1ab378b7a8f5c63fc697 > Cr-Commit-Position: refs/heads/master@{#420103} TBR=creis@chromium.org,nasko@chromium.org,nick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=646278 Committed: https://crrev.com/5a79414a791d28d516e2b5b24b71a25451a8cf75 Cr-Commit-Position: refs/heads/master@{#420132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -248 lines) Patch
D content/browser/blob_storage/blob_url_browsertest.cc View 1 chunk +0 lines, -188 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dewittj
Created Revert of Disallow navigations to blob URLs with non-canonical origins.
4 years, 3 months ago (2016-09-21 19:18:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358193002/1
4 years, 3 months ago (2016-09-21 19:19:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 19:19:52 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 19:23:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a79414a791d28d516e2b5b24b71a25451a8cf75
Cr-Commit-Position: refs/heads/master@{#420132}

Powered by Google App Engine
This is Rietveld 408576698