Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2358133005: Remove Linux ChromiumOS GN build configs from //testing/buildbot. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
dnj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Linux ChromiumOS GN build configs from //testing/buildbot. Since the builders are being removed. R=dnj@chromium.org BUG=649579 Committed: https://crrev.com/db2d32bad02502469817f77907508018f89b9a52 Cr-Commit-Position: refs/heads/master@{#420727}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 1 chunk +0 lines, -56 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 3 comments Download

Messages

Total messages: 13 (6 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-23 17:36:22 UTC) #1
dnj
https://codereview.chromium.org/2358133005/diff/1/testing/buildbot/gn_isolate_map.pyl File testing/buildbot/gn_isolate_map.pyl (left): https://codereview.chromium.org/2358133005/diff/1/testing/buildbot/gn_isolate_map.pyl#oldcode469 testing/buildbot/gn_isolate_map.pyl:469: "gn_unittests": { Is this still relevant?
4 years, 3 months ago (2016-09-23 17:37:09 UTC) #2
Dirk Pranke
https://codereview.chromium.org/2358133005/diff/1/testing/buildbot/gn_isolate_map.pyl File testing/buildbot/gn_isolate_map.pyl (left): https://codereview.chromium.org/2358133005/diff/1/testing/buildbot/gn_isolate_map.pyl#oldcode469 testing/buildbot/gn_isolate_map.pyl:469: "gn_unittests": { On 2016/09/23 17:37:09, dnj wrote: > Is ...
4 years, 3 months ago (2016-09-23 17:42:02 UTC) #3
dnj
lgtm https://codereview.chromium.org/2358133005/diff/1/testing/buildbot/gn_isolate_map.pyl File testing/buildbot/gn_isolate_map.pyl (left): https://codereview.chromium.org/2358133005/diff/1/testing/buildbot/gn_isolate_map.pyl#oldcode469 testing/buildbot/gn_isolate_map.pyl:469: "gn_unittests": { On 2016/09/23 17:42:02, Dirk Pranke wrote: ...
4 years, 3 months ago (2016-09-23 17:54:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358133005/1
4 years, 3 months ago (2016-09-23 20:56:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 21:05:49 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 21:08:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db2d32bad02502469817f77907508018f89b9a52
Cr-Commit-Position: refs/heads/master@{#420727}

Powered by Google App Engine
This is Rietveld 408576698