Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 2358133002: Turn //mojo/public/cpp/bindings and //mojo/public/cpp/system into components (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index be36cb49d6200e1ea6742b1bceeb4a5bcbd6aba6..757e06efb07ddc62b41aa28ec3ce358050db1ce9 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -204,6 +204,10 @@ template("mojom") {
full_name = get_label_info("$d", "label_no_toolchain")
public_deps += [ "${full_name}_${shared_cpp_sources_suffix}" ]
}
+ defines = []
+ if (defined(invoker.export_define)) {
+ defines += [ invoker.export_define ]
yzshen1 2016/09/22 18:26:27 Why this is needed?
yzshen1 2016/09/22 18:34:10 Just saw your comments. Let me think about it some
yzshen1 2016/09/22 19:39:36 It seems a little hacky because invoker.export_def
dcheng 2016/09/22 22:18:21 It's very hacky. I like your solution better. =)
+ }
}
# Generate code for variants.
« mojo/public/cpp/system/system_export.h ('K') | « mojo/public/interfaces/bindings/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698