Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: mojo/public/cpp/bindings/message.h

Issue 2358133002: Turn //mojo/public/cpp/bindings and //mojo/public/cpp/system into components (Closed)
Patch Set: Fix wording Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/validation_util.h ('k') | mojo/public/cpp/bindings/message_header_validator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/message.h
diff --git a/mojo/public/cpp/bindings/message.h b/mojo/public/cpp/bindings/message.h
index 9cce92c8e0419cfa2b7f7c04b7d2e485e1af654b..cfb9d05f6011aa41827250a8262200421ab06ff0 100644
--- a/mojo/public/cpp/bindings/message.h
+++ b/mojo/public/cpp/bindings/message.h
@@ -14,7 +14,9 @@
#include <vector>
#include "base/callback.h"
+#include "base/compiler_specific.h"
#include "base/logging.h"
+#include "mojo/public/cpp/bindings/bindings_export.h"
#include "mojo/public/cpp/bindings/lib/message_buffer.h"
#include "mojo/public/cpp/bindings/lib/message_internal.h"
#include "mojo/public/cpp/system/message.h"
@@ -27,7 +29,7 @@ using ReportBadMessageCallback = base::Callback<void(const std::string& error)>;
// Message owns its data and handles, but a consumer of Message is free to
// mutate the data and handles. The message's data is comprised of a header
// followed by payload.
-class Message {
+class MOJO_CPP_BINDINGS_EXPORT Message {
public:
static const uint32_t kFlagExpectsResponse = 1 << 0;
static const uint32_t kFlagIsResponse = 1 << 1;
@@ -200,7 +202,8 @@ class MessageReceiverWithResponderStatus : public MessageReceiver {
WARN_UNUSED_RESULT = 0;
};
-class PassThroughFilter : public MessageReceiver {
+class MOJO_CPP_BINDINGS_EXPORT PassThroughFilter
+ : NON_EXPORTED_BASE(public MessageReceiver) {
public:
PassThroughFilter();
~PassThroughFilter() override;
@@ -229,7 +232,7 @@ class SyncMessageResponseSetup;
// if (response_value.IsBad())
// response_context.ReportBadMessage("Bad response_value!");
//
-class SyncMessageResponseContext {
+class MOJO_CPP_BINDINGS_EXPORT SyncMessageResponseContext {
public:
SyncMessageResponseContext();
~SyncMessageResponseContext();
@@ -264,6 +267,7 @@ MojoResult ReadMessage(MessagePipeHandle handle, Message* message);
// you need to do asynchronous work before you can determine the legitimacy of
// a message, use TakeBadMessageCallback() and retain its result until you're
// ready to invoke or discard it.
+MOJO_CPP_BINDINGS_EXPORT
void ReportBadMessage(const std::string& error);
// Acquires a callback which may be run to report the currently dispatching
@@ -271,6 +275,7 @@ void ReportBadMessage(const std::string& error);
// stack frame of a message dispatch, but the returned callback may be called
// exactly once any time thereafter to report the message as bad. This may only
// be called once per message.
+MOJO_CPP_BINDINGS_EXPORT
ReportBadMessageCallback GetBadMessageCallback();
} // namespace mojo
« no previous file with comments | « mojo/public/cpp/bindings/lib/validation_util.h ('k') | mojo/public/cpp/bindings/message_header_validator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698