Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 235813002: Add profile-switches to signin-internals; move switches to component (Closed)

Created:
6 years, 8 months ago by Mike Lerman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, sadrul, tfarina, haitaol+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, ben+ash_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add profile-switches to signin-internals; move switches to component The profile related switches have been moved from chrome/common to components/signin/core/common. BUG=326577 TEST=chrome://signin-internals page should accurately reflect the status of the Web Enabled Sign In and New Profile Management Flags. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264056

Patch Set 1 #

Patch Set 2 : Fix gyp(i) files #

Total comments: 4

Patch Set 3 : Nits and new files #

Patch Set 4 : Rebase #

Patch Set 5 : bools IN lower CASE #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -190 lines) Patch
M chrome/browser/android/signin/signin_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/principals_private/principals_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/avatar_menu.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_list_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_promo.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_tracker_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 chunks +0 lines, -21 lines 0 comments Download
D chrome/common/profile_management_switches.h View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/common/profile_management_switches.cc View 1 2 3 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M components/signin.gypi View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M components/signin/core/browser/about_signin_internals.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
A + components/signin/core/common/profile_management_switches.h View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
A + components/signin/core/common/profile_management_switches.cc View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M components/signin/core/common/signin_switches.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M components/signin/core/common/signin_switches.cc View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Mike Lerman
Hey Roger, Can you do a review of the base changes I made to components/ ...
6 years, 8 months ago (2014-04-11 20:31:31 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/235813002/diff/10001/chrome/common/profile_management_switches.cc File chrome/common/profile_management_switches.cc (left): https://codereview.chromium.org/235813002/diff/10001/chrome/common/profile_management_switches.cc#oldcode59 chrome/common/profile_management_switches.cc:59: } Put in same order as .h file. ...
6 years, 8 months ago (2014-04-11 20:57:42 UTC) #2
Mike Lerman
Roger, I've addressed the nits you made. Jochen, can you please review my broad refactoring? ...
6 years, 8 months ago (2014-04-14 19:39:53 UTC) #3
msarda
On 2014/04/14 19:39:53, Mike Lerman wrote: > Roger, I've addressed the nits you made. > ...
6 years, 8 months ago (2014-04-15 08:17:11 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-15 09:53:00 UTC) #5
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 8 months ago (2014-04-15 13:00:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/235813002/30001
6 years, 8 months ago (2014-04-15 13:03:00 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 13:03:26 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/common/chrome_switches.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-15 13:03:26 UTC) #9
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 8 months ago (2014-04-15 14:54:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/235813002/50001
6 years, 8 months ago (2014-04-15 14:54:39 UTC) #11
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 8 months ago (2014-04-15 15:54:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/235813002/70001
6 years, 8 months ago (2014-04-15 15:55:14 UTC) #13
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 8 months ago (2014-04-15 16:00:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/235813002/90001
6 years, 8 months ago (2014-04-15 16:01:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/235813002/90001
6 years, 8 months ago (2014-04-16 01:20:35 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 01:44:56 UTC) #17
Message was sent while issue was closed. 
Change committed as 264056

Powered by Google App Engine
This is Rietveld 408576698