Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2358123002: Subzero, MIPS32: Remove duplicate functionalities (Closed)

Created:
4 years, 3 months ago by obucinac
Modified:
4 years, 3 months ago
CC:
native-client-reviews_googlegroups.com, rich_fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero, MIPS32: Remove duplicate functionalities Removes lowering functions functionalities already covered by genTargetHelperCallFor. Adds error messages for appropriate cases. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f5d8e0977c0908986373d18293951c8af091e356

Patch Set 1 #

Patch Set 2 : Remove empty line #

Patch Set 3 : Added new info lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -42 lines) Patch
M src/IceTargetLoweringMIPS32.cpp View 1 2 8 chunks +53 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
obucinac
4 years, 3 months ago (2016-09-21 17:40:52 UTC) #3
Jim Stichnoth
lgtm
4 years, 3 months ago (2016-09-22 14:04:50 UTC) #7
Jim Stichnoth
4 years, 3 months ago (2016-09-22 14:05:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f5d8e0977c0908986373d18293951c8af091e356 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698