Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2358083003: [remoting android] Remove host It2Me implementation. (Closed)

Created:
4 years, 3 months ago by Lambros
Modified:
4 years, 3 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Remove host It2Me implementation. For the record, in case we decide to bring this back, there is also an un-landed CL at https://codereview.chromium.org/1917063002/ BUG=648670 Committed: https://crrev.com/429625d84b4d1f3073d4a1535530279436f8e790 Cr-Commit-Position: refs/heads/master@{#420473}

Patch Set 1 #

Patch Set 2 : Update remoting_enable.gni #

Patch Set 3 : Update remoting/host/it2me/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1007 lines) Patch
M remoting/android/BUILD.gn View 2 chunks +0 lines, -50 lines 0 comments Download
D remoting/android/host/AndroidManifest.xml View 1 chunk +0 lines, -27 lines 0 comments Download
D remoting/android/host/res/layout/main.xml View 1 chunk +0 lines, -47 lines 0 comments Download
D remoting/android/host/src/org/chromium/chromoting/host/MainActivity.java View 1 chunk +0 lines, -115 lines 0 comments Download
D remoting/android/host/src/org/chromium/chromoting/host/RemotingApplication.java View 1 chunk +0 lines, -18 lines 0 comments Download
D remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java View 1 chunk +0 lines, -78 lines 0 comments Download
D remoting/android/host/src/org/chromium/chromoting/host/jni/It2MeHostObserver.java View 1 chunk +0 lines, -34 lines 0 comments Download
M remoting/host/BUILD.gn View 11 chunks +1 line, -20 lines 0 comments Download
D remoting/host/android/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D remoting/host/android/jni_host.h View 1 chunk +0 lines, -69 lines 0 comments Download
D remoting/host/android/jni_host.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D remoting/host/android/remoting_host_jni_onload.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D remoting/host/android/remoting_host_jni_registrar.h View 1 chunk +0 lines, -17 lines 0 comments Download
D remoting/host/android/remoting_host_jni_registrar.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D remoting/host/audio_capturer_android.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D remoting/host/continue_window_android.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D remoting/host/curtain_mode_android.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D remoting/host/desktop_resizer_android.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D remoting/host/disconnect_window_android.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D remoting/host/input_injector_android.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 2 3 chunks +1 line, -9 lines 0 comments Download
D remoting/host/it2me/it2me_confirmation_dialog_android.cc View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D remoting/host/local_input_monitor_android.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D remoting/host/pairing_registry_delegate_android.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D remoting/host/resources_android.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M remoting/remoting_enable.gni View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Lambros
4 years, 3 months ago (2016-09-22 01:08:46 UTC) #4
joedow
lgtm after you remove it2me_confirmation_dialog_android.cc and update the It2Me build.gn file.
4 years, 3 months ago (2016-09-22 02:34:01 UTC) #5
Lambros
On 2016/09/22 02:34:01, joedow wrote: > lgtm after you remove it2me_confirmation_dialog_android.cc and update the It2Me ...
4 years, 3 months ago (2016-09-22 20:55:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358083003/40001
4 years, 3 months ago (2016-09-22 20:56:37 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 22:01:32 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 22:03:09 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/429625d84b4d1f3073d4a1535530279436f8e790
Cr-Commit-Position: refs/heads/master@{#420473}

Powered by Google App Engine
This is Rietveld 408576698