Make ownership explicit in CPDF_ContentMarkItem

Make ownership explicit in CPDF_ContentMarkItem.

The old SetParam() method had "maybe take ownership" semanitcs
based upon the type argument.

Make GetParam() handle the None case and simplify callers
based upon that behaviour.

Committed: https://pdfium.googlesource.com/pdfium/+/17103b84ebde9ab2b05dff38d473b5d44f723ff2

[Tom Sepez, 2016-09-21 19:25:12]

Description was changed from

==========
Make ownership explicit in CPDF_ContentMarkItem
==========

to

==========
Make ownership explicit in CPDF_ContentMarkItem.

The old SetParam() method had "maybe take ownership" semanitcs
based upon the type argument.

Make GetParam() handle the None case and simplify callers
based upon that behaviour.
==========

[Tom Sepez, 2016-09-21 19:25:12]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-21 19:27:21]

Dan, for review.

[Tom Sepez, 2016-09-21 19:27:28]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:27:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-09-21 19:34:43]

https://codereview.chromium.org/2358043003/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_contentmarkitem.h (right):

https://codereview.chromium.org/2358043003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_contentmarkitem.h:8: #define
CORE_FPDFAPI_FPDF_PAGE_CPDF_CONTENTMARKITEM_H_
#include <memory>

https://codereview.chromium.org/2358043003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_contentmarkitem.h:39: CPDF_Dictionary*
m_pPropertiesDict;
nit: Add a not owned comment?

https://codereview.chromium.org/2358043003/diff/20001/core/fpdftext/cpdf_text...
File core/fpdftext/cpdf_textpage.cpp (right):

https://codereview.chromium.org/2358043003/diff/20001/core/fpdftext/cpdf_text...
core/fpdftext/cpdf_textpage.cpp:824: CPDF_String* temp =
ToString(pDict->GetObjectFor("ActualText"));
Can't this still, possibly be null, if we called SetPropertyDict(nullptr)?

[commit-bot: I haz the power, 2016-09-21 20:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:04:34]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-21 20:04:44]

https://codereview.chromium.org/2358043003/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_contentmarkitem.h (right):

https://codereview.chromium.org/2358043003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_contentmarkitem.h:8: #define
CORE_FPDFAPI_FPDF_PAGE_CPDF_CONTENTMARKITEM_H_
On 2016/09/21 19:34:43, dsinclair wrote:
> #include <memory>

Done.

https://codereview.chromium.org/2358043003/diff/20001/core/fpdftext/cpdf_text...
File core/fpdftext/cpdf_textpage.cpp (right):

https://codereview.chromium.org/2358043003/diff/20001/core/fpdftext/cpdf_text...
core/fpdftext/cpdf_textpage.cpp:824: CPDF_String* temp =
ToString(pDict->GetObjectFor("ActualText"));
On 2016/09/21 19:34:43, dsinclair wrote:
> Can't this still, possibly be null, if we called SetPropertyDict(nullptr)?

Either way, pDict is assigned to nullptr, and we continue at 823.

[dsinclair, 2016-09-21 20:06:11]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-21 20:06:11]

lgtm

[commit-bot: I haz the power, 2016-09-21 20:06:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-21 20:06:50]

https://codereview.chromium.org/2358043003/diff/20001/core/fpdfapi/fpdf_page/...
File core/fpdfapi/fpdf_page/cpdf_contentmarkitem.h (right):

https://codereview.chromium.org/2358043003/diff/20001/core/fpdfapi/fpdf_page/...
core/fpdfapi/fpdf_page/cpdf_contentmarkitem.h:39: CPDF_Dictionary*
m_pPropertiesDict;
On 2016/09/21 19:34:43, dsinclair wrote:
> nit: Add a not owned comment?

will do.

[Tom Sepez, 2016-09-21 20:08:45]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-09-21 20:08:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2358043003/#ps60001
(title: "Not owned")

[commit-bot: I haz the power, 2016-09-21 20:08:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 20:30:34]

Description was changed from

==========
Make ownership explicit in CPDF_ContentMarkItem.

The old SetParam() method had "maybe take ownership" semanitcs
based upon the type argument.

Make GetParam() handle the None case and simplify callers
based upon that behaviour.
==========

to

==========
Make ownership explicit in CPDF_ContentMarkItem.

The old SetParam() method had "maybe take ownership" semanitcs
based upon the type argument.

Make GetParam() handle the None case and simplify callers
based upon that behaviour.

Committed:
https://pdfium.googlesource.com/pdfium/+/17103b84ebde9ab2b05dff38d473b5d44f72...
==========

[commit-bot: I haz the power, 2016-09-21 20:30:35]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/17103b84ebde9ab2b05dff38d473b5d44f72...