Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2358023003: Call StatisticsRecorder::Initialize when a GlobalHistogramAllocator is created. (Closed)

Created:
4 years, 3 months ago by bcwhite
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The GHA won't function properly if the SR hasn't been initialized so do that. Also: Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494, crashpad:100 Committed: https://crrev.com/0ad9ed389930c020268e251c454e004f5a9538be Cr-Commit-Position: refs/heads/master@{#420402}

Patch Set 1 : import of new code by scott, plus some debug code #

Patch Set 2 : more testing #

Patch Set 3 : handle Initialize() when local SR is active #

Patch Set 4 : removed debugging code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M base/metrics/persistent_histogram_allocator.cc View 2 3 1 chunk +5 lines, -1 line 0 comments Download
M base/metrics/statistics_recorder.cc View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
scottmg
Thanks for debugging! Can you add BUG=648494, crashpad:100 to the description too?
4 years, 3 months ago (2016-09-22 00:15:32 UTC) #8
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-22 18:18:55 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358023003/90001
4 years, 3 months ago (2016-09-22 18:20:23 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:90001)
4 years, 3 months ago (2016-09-22 18:26:41 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:32:04 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0ad9ed389930c020268e251c454e004f5a9538be
Cr-Commit-Position: refs/heads/master@{#420402}

Powered by Google App Engine
This is Rietveld 408576698