|
|
DescriptionThe GHA won't function properly if the SR hasn't been initialized so do that.
Also: Fix problem with initialization of the global SR when a local
SR is already active for testing purposes.
BUG=648494, crashpad:100
Committed: https://crrev.com/0ad9ed389930c020268e251c454e004f5a9538be
Cr-Commit-Position: refs/heads/master@{#420402}
Patch Set 1 : import of new code by scott, plus some debug code #Patch Set 2 : more testing #Patch Set 3 : handle Initialize() when local SR is active #Patch Set 4 : removed debugging code #Messages
Total messages: 26 (21 generated)
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bcwhite@chromium.org
Patchset #3 (id:30001) has been deleted
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
scottmg@chromium.org changed reviewers: + scottmg@chromium.org
Thanks for debugging! Can you add BUG=648494, crashpad:100 to the description too?
Description was changed from ========== Call StatisticsRecorder::Initialize in GlobalHistogramAllocator's ctor patch from issue 2354363002 at patchset 40001 (http://crrev.com/2354363002#ps40001) BUG= ========== to ========== Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494 ==========
bcwhite@chromium.org changed reviewers: - scottmg@chromium.org
Description was changed from ========== Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494 ========== to ========== Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494, crashpad:100 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #5 (id:110001) has been deleted
Description was changed from ========== Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494, crashpad:100 ========== to ========== The GHA won't function properly if the SR hasn't been initialized so do that. Also: Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494, crashpad:100 ==========
bcwhite@chromium.org changed reviewers: + asvitkine@chromium.org, scottmg@chromium.org
lgtm
The CQ bit was checked by bcwhite@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== The GHA won't function properly if the SR hasn't been initialized so do that. Also: Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494, crashpad:100 ========== to ========== The GHA won't function properly if the SR hasn't been initialized so do that. Also: Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494, crashpad:100 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:90001)
Message was sent while issue was closed.
Description was changed from ========== The GHA won't function properly if the SR hasn't been initialized so do that. Also: Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494, crashpad:100 ========== to ========== The GHA won't function properly if the SR hasn't been initialized so do that. Also: Fix problem with initialization of the global SR when a local SR is already active for testing purposes. BUG=648494, crashpad:100 Committed: https://crrev.com/0ad9ed389930c020268e251c454e004f5a9538be Cr-Commit-Position: refs/heads/master@{#420402} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0ad9ed389930c020268e251c454e004f5a9538be Cr-Commit-Position: refs/heads/master@{#420402} |