Don't send a value changed notification when a characteristic is written

Bluetooth: mac: When a characteristic is written, a gatt characteristic value changed notification is send.
This notification should not be sent since.

BUG=647500
Committed: https://crrev.com/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d
Cr-Commit-Position: refs/heads/master@{#423337}

[jlebel, 2016-09-21 14:24:53]

Description was changed from

==========
Don't send a value changed notification when a characteristic is written

BUG=647500
==========

to

==========
Bluetooth: mac: When a characteristic is written, a gatt characteristic value
changed notification is send.
This notification should not be sent since.

BUG=647500
==========

[jlebel, 2016-09-21 14:25:02]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 14:25:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2016-09-21 15:13:19]

jlebel@chromium.org changed reviewers:
+ ortuno@chromium.org

[jlebel, 2016-09-21 15:13:20]

Hello Giovanni,

Can you review this patch to fix notification while writing characteristic?

Thanks,

[jlebel, 2016-09-21 15:13:38]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 15:14:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 16:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 16:48:12]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-09-21 23:23:25]

Could you also update the relevant tests to make sure no event was dispatched
and the value hasn't changed?

[jlebel, 2016-10-05 14:53:22]

On 2016/09/21 23:23:25, ortuno wrote:
> Could you also update the relevant tests to make sure no event was dispatched
> and the value hasn't changed?

Done.

[jlebel, 2016-10-05 14:53:51]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 14:54:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 15:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 15:06:06]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ortuno, 2016-10-05 21:42:23]

https://codereview.chromium.org/2357993002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2357993002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:566:
characteristic1_->ReadRemoteCharacteristic(
I'm not sure why you are adding this?

[jlebel, 2016-10-05 22:07:38]

Should exclude windows for that test? I guess I should create a bug for it?

https://codereview.chromium.org/2357993002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2357993002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:566:
characteristic1_->ReadRemoteCharacteristic(
On 2016/10/05 21:42:23, ortuno wrote:
> I'm not sure why you are adding this?

Done.

[ortuno, 2016-10-05 22:13:50]

lgtm with windows #if defined and comment pointing to the issue

https://codereview.chromium.org/2357993002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2357993002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:573:
EXPECT_EQ(0, observer.gatt_characteristic_value_changed_count());
You can add a #if !defined(OS_WIN) and point to the issue you are opening.

[jlebel, 2016-10-05 22:32:32]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2016-10-05 22:32:33]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2357993002/#ps80001
(title: "Adding #if to avoid the test for windows (and with the todo and the bug
number)")

[commit-bot: I haz the power, 2016-10-05 22:33:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2016-10-05 22:35:36]

https://codereview.chromium.org/2357993002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2357993002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc:573:
EXPECT_EQ(0, observer.gatt_characteristic_value_changed_count());
On 2016/10/05 22:13:50, ortuno wrote:
> You can add a #if !defined(OS_WIN) and point to the issue you are opening.

Done.

[jlebel, 2016-10-05 23:20:37]

The CQ bit was unchecked by jlebel@chromium.org

[jlebel, 2016-10-05 23:23:56]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2016-10-05 23:24:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 23:34:03]

Description was changed from

==========
Bluetooth: mac: When a characteristic is written, a gatt characteristic value
changed notification is send.
This notification should not be sent since.

BUG=647500
==========

to

==========
Bluetooth: mac: When a characteristic is written, a gatt characteristic value
changed notification is send.
This notification should not be sent since.

BUG=647500
==========

[commit-bot: I haz the power, 2016-10-05 23:34:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-05 23:35:50]

Description was changed from

==========
Bluetooth: mac: When a characteristic is written, a gatt characteristic value
changed notification is send.
This notification should not be sent since.

BUG=647500
==========

to

==========
Bluetooth: mac: When a characteristic is written, a gatt characteristic value
changed notification is send.
This notification should not be sent since.

BUG=647500

Committed: https://crrev.com/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d
Cr-Commit-Position: refs/heads/master@{#423337}
==========

[commit-bot: I haz the power, 2016-10-05 23:35:52]

Patchset 5 (id:??) landed as
https://crrev.com/0405e3b684cf2cddeadacbe13c035a3eb0bdd80d
Cr-Commit-Position: refs/heads/master@{#423337}