Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2357983006: Remove unused/unnecessary code from the external protocol dialog for ARC (Closed)

Created:
4 years, 3 months ago by Yusuke Sato
Modified:
4 years, 3 months ago
Reviewers:
djacobo_
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused/unnecessary code from the external protocol dialog for ARC BUG=b:31665510 TEST=try, also manually confirmed that Always button still works Committed: https://crrev.com/fc93acb7769a93198ce156d326f1397eac28d49f Cr-Commit-Position: refs/heads/master@{#420470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yusuke Sato
PTAL
4 years, 3 months ago (2016-09-22 20:51:08 UTC) #4
djacobo_
lgtm
4 years, 3 months ago (2016-09-22 21:37:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357983006/1
4 years, 3 months ago (2016-09-22 21:39:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 21:45:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 21:50:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc93acb7769a93198ce156d326f1397eac28d49f
Cr-Commit-Position: refs/heads/master@{#420470}

Powered by Google App Engine
This is Rietveld 408576698