Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2357983005: Site Settings Desktop: Support SessionOnly for cookies on Site Details page. (Closed)

Created:
4 years, 3 months ago by Finnur
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Support SessionOnly for cookies on Site Details page. BUG=614277 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/67700e6cd9931ffcffd8b0beb1ab8b014aa58b53 Cr-Commit-Position: refs/heads/master@{#420895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
M chrome/browser/resources/settings/site_settings/site_details_permission.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details_permission.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/site_details_permission_tests.js View 4 chunks +56 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Finnur
Discovered during a test pass through the UI that this was missing...
4 years, 3 months ago (2016-09-22 13:45:32 UTC) #5
dschuyler
lgtm
4 years, 3 months ago (2016-09-22 18:23:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357983005/1
4 years, 2 months ago (2016-09-26 09:44:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286007)
4 years, 2 months ago (2016-09-26 10:26:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357983005/1
4 years, 2 months ago (2016-09-26 10:43:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147934)
4 years, 2 months ago (2016-09-26 12:19:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357983005/1
4 years, 2 months ago (2016-09-26 13:12:27 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 15:52:56 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 15:54:45 UTC) #21
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/67700e6cd9931ffcffd8b0beb1ab8b014aa58b53
Cr-Commit-Position: refs/heads/master@{#420895}

Powered by Google App Engine
This is Rietveld 408576698