Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2357983004: base: Allow renderer thread priorities to be changed. (Closed)

Created:
4 years, 3 months ago by reveman
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

base: Allow renderer thread priorities to be changed. This provides a mechanism for a renderer to change the priority of its threads and as a result also the cpuset they are assigned to. A ChildProcessHost IPC message from the renderer is used to request a thread priority change and have the browser process identify the renderer thread that is requesting a priority change by checking all its threads to find a thread with NSpid field in /proc/[pid]/task/[thread_id]/status that matches the namespace tid from the renderer. This is currently limited to Linux and ChromeOS but follow up work will investigate the possibility and benefits of doing the same on other platforms. Note: Thread priorities in the renderer are already adjusted in a similar way on Android as the sandbox is not strict enough to prevent this on Android today. BUG=chrome-os-partner:56550 TEST= Review-Url: https://codereview.chromium.org/2334533002 Cr-Commit-Position: refs/heads/master@{#419649} (cherry picked from commit 7b97c3240fb3da0826f244f9b592fc1761fb6554) Committed: https://chromium.googlesource.com/chromium/src/+/b3d944286ca79ccbcdfb693818fff72908577152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -23 lines) Patch
M base/linux_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M base/linux_util.cc View 4 chunks +68 lines, -23 lines 0 comments Download
M base/threading/platform_thread.h View 1 chunk +14 lines, -0 lines 0 comments Download
M base/threading/platform_thread_linux.cc View 4 chunks +60 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +38 lines, -0 lines 0 comments Download
M content/child/child_process.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/child_process.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/common/child_process_messages.h View 3 chunks +16 lines, -0 lines 0 comments Download
M content/renderer/categorized_worker_pool.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
reveman
4 years, 3 months ago (2016-09-22 00:15:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3d944286ca79ccbcdfb693818fff72908577152.

Powered by Google App Engine
This is Rietveld 408576698