Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2357963002: GN: is_skia_standalone (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: is_skia_standalone is_skia_standalone will be defined and set to true iff we're using our standalone BUILDCONFIG.gn. Any other build (Fuchsia, Chrome, Pdfium) will have their own BUILDCONFIG.gn, which presumably does not define is_skia_standalone. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357963002 Committed: https://skia.googlesource.com/skia/+/3e8012e74f70bf49427a7422f9e5996c9882d4f3

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M BUILD.gn View 1 2 chunks +6 lines, -4 lines 0 comments Download
M gn/BUILDCONFIG.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
mtklein_C
4 years, 3 months ago (2016-09-21 13:53:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357963002/1
4 years, 3 months ago (2016-09-21 13:53:45 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-21 13:53:47 UTC) #6
egdaniel
lgtm
4 years, 3 months ago (2016-09-21 13:59:50 UTC) #7
mtklein_C
On 2016/09/21 at 13:59:50, egdaniel wrote: > lgtm (Will let yours land first.)
4 years, 3 months ago (2016-09-21 14:04:37 UTC) #10
mtklein_C
Rebased in the obvious way.
4 years, 3 months ago (2016-09-21 15:35:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357963002/20001
4 years, 3 months ago (2016-09-21 15:35:21 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 16:14:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3e8012e74f70bf49427a7422f9e5996c9882d4f3

Powered by Google App Engine
This is Rietveld 408576698