Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2357953002: Add define of SK_ENABLE_VK_LAYERS to gn build (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add define of SK_ENABLE_VK_LAYERS to gn build BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357953002 Committed: https://skia.googlesource.com/skia/+/e4a9bd79c676346ada8f4c35fa3a7fd99dfc5544

Patch Set 1 #

Total comments: 2

Patch Set 2 : turn off for fuchsia #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M BUILD.gn View 1 2 chunks +6 lines, -0 lines 0 comments Download
M infra/bots/recipe_modules/flavor/gn_android_flavor.py View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-arm64-Release-GN_Android_Vulkan.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
egdaniel
4 years, 3 months ago (2016-09-21 13:45:56 UTC) #3
mtklein
https://codereview.chromium.org/2357953002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2357953002/diff/1/BUILD.gn#newcode25 BUILD.gn:25: # TODO: Vulkan debug layers should be disabled for ...
4 years, 3 months ago (2016-09-21 13:47:44 UTC) #4
egdaniel
https://codereview.chromium.org/2357953002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2357953002/diff/1/BUILD.gn#newcode25 BUILD.gn:25: # TODO: Vulkan debug layers should be disabled for ...
4 years, 3 months ago (2016-09-21 13:52:37 UTC) #5
mtklein
lgtm
4 years, 3 months ago (2016-09-21 13:54:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357953002/20001
4 years, 3 months ago (2016-09-21 13:54:33 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 14:36:18 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e4a9bd79c676346ada8f4c35fa3a7fd99dfc5544

Powered by Google App Engine
This is Rietveld 408576698