Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2357913003: Remove calls to MessageLoop::Run/RunUntilIdle from ios/. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::Run/RunUntilIdle from ios/. These methods are deprecated. RunLoop must be used instead. BUG=616447 Committed: https://crrev.com/2d6df49caba9889e7186f59e08609e041405227a Cr-Commit-Position: refs/heads/master@{#420282}

Patch Set 1 #

Patch Set 2 : add missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M ios/chrome/app/application_delegate/memory_warning_helper_unittest.mm View 1 3 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/web_resource/web_resource_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/net/request_tracker_impl_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-21 16:37:36 UTC) #4
sdefresne
lgtm
4 years, 3 months ago (2016-09-22 08:08:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357913003/20001
4 years, 3 months ago (2016-09-22 08:08:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 08:13:20 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 08:14:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d6df49caba9889e7186f59e08609e041405227a
Cr-Commit-Position: refs/heads/master@{#420282}

Powered by Google App Engine
This is Rietveld 408576698