Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1606)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 23579009: [rAc] Move email address into billing address section. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Include email address in suggestion preview text, fix some compile errors (unittests need more fixi… Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
index 00b17ffde6d9e2730087e6fd88b7154b05896d66..6c97ee3702fcb805bb85411150067ef6510b06a6 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
@@ -814,7 +814,6 @@ TEST_F(AutofillDialogControllerTest, AutofillProfiles) {
// suggestion.
EXPECT_FALSE(controller()->MenuModelForSection(SECTION_CC));
EXPECT_FALSE(controller()->MenuModelForSection(SECTION_BILLING));
- EXPECT_FALSE(controller()->MenuModelForSection(SECTION_EMAIL));
EXPECT_CALL(*controller()->GetView(), ModelChanged()).Times(3);
@@ -825,7 +824,6 @@ TEST_F(AutofillDialogControllerTest, AutofillProfiles) {
shipping_model = controller()->MenuModelForSection(SECTION_SHIPPING);
ASSERT_TRUE(shipping_model);
EXPECT_EQ(3, shipping_model->GetItemCount());
- EXPECT_FALSE(controller()->MenuModelForSection(SECTION_EMAIL));
// An otherwise full but unverified profile should be ignored.
AutofillProfile full_profile(test::GetFullProfile());
@@ -835,7 +833,6 @@ TEST_F(AutofillDialogControllerTest, AutofillProfiles) {
shipping_model = controller()->MenuModelForSection(SECTION_SHIPPING);
ASSERT_TRUE(shipping_model);
EXPECT_EQ(3, shipping_model->GetItemCount());
- EXPECT_FALSE(controller()->MenuModelForSection(SECTION_EMAIL));
// A full, verified profile should be picked up.
AutofillProfile verified_profile(test::GetVerifiedProfile());
@@ -844,7 +841,6 @@ TEST_F(AutofillDialogControllerTest, AutofillProfiles) {
shipping_model = controller()->MenuModelForSection(SECTION_SHIPPING);
ASSERT_TRUE(shipping_model);
EXPECT_EQ(4, shipping_model->GetItemCount());
- EXPECT_TRUE(!!controller()->MenuModelForSection(SECTION_EMAIL));
}
// Makes sure that the choice of which Autofill profile to use for each section
@@ -1596,40 +1592,6 @@ TEST_F(AutofillDialogControllerTest, AddAutofillProfile) {
added_profile.GetInfo(AutofillType(EMAIL_ADDRESS), "en-US"));
}
-// Makes sure that a newly added email address gets added to an existing profile
-// (as opposed to creating its own profile). http://crbug.com/240926
-TEST_F(AutofillDialogControllerTest, AddEmail) {
- SwitchToAutofill();
- EXPECT_CALL(*controller()->GetView(), ModelChanged()).Times(2);
-
- AutofillProfile full_profile(test::GetVerifiedProfile());
- CreditCard credit_card(test::GetVerifiedCreditCard());
- controller()->GetTestingManager()->AddTestingProfile(&full_profile);
- controller()->GetTestingManager()->AddTestingCreditCard(&credit_card);
-
- ui::MenuModel* model = controller()->MenuModelForSection(SECTION_EMAIL);
- ASSERT_TRUE(model);
- // Activate the "Add email address" menu item.
- model->ActivatedAt(model->GetItemCount() - 2);
-
- // Fill in the inputs from the profile.
- DetailOutputMap outputs;
- const DetailInputs& inputs =
- controller()->RequestedFieldsForSection(SECTION_EMAIL);
- const DetailInput& input = inputs[0];
- string16 new_email = ASCIIToUTF16("addemailtest@example.com");
- outputs[&input] = new_email;
- controller()->GetView()->SetUserInput(SECTION_EMAIL, outputs);
-
- FillCreditCardInputs();
- controller()->OnAccept();
- std::vector<base::string16> email_values;
- full_profile.GetMultiInfo(
- AutofillType(EMAIL_ADDRESS), "en-US", &email_values);
- ASSERT_EQ(2U, email_values.size());
- EXPECT_EQ(new_email, email_values[1]);
-}
-
TEST_F(AutofillDialogControllerTest, VerifyCvv) {
EXPECT_CALL(*controller()->GetTestingWalletClient(),
GetFullWallet(_)).Times(1);

Powered by Google App Engine
This is Rietveld 408576698