[rAc] Move email address into billing address section.

[rAc] Move email address into billing address section.

BUG=258612
TEST=email address appears under billing address section (in Autofill mode) and
     is still filled correctly (in both modes)

R=estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221912

[Evan Stade, 2013-09-05 16:54:09]

lgtm

https://codereview.chromium.org/23579009/diff/6001/chrome/browser/ui/autofill...
File chrome/browser/ui/autofill/autofill_dialog_common.cc (right):

https://codereview.chromium.org/23579009/diff/6001/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/autofill_dialog_common.cc:133:
arraysize(kBillingInputs) - 1,  // Skip the email field.
hmmm, maybe it would be cleaner to add the email in the SECTION_BILLING case
rather than removing it in the CC_BILLING case

https://codereview.chromium.org/23579009/diff/6001/chrome/browser/ui/autofill...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/23579009/diff/6001/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1371: }
DCHECK_EQ(SECTION_BILLING, section)?

https://codereview.chromium.org/23579009/diff/6001/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2454:
profiles[i]->GetRawInfo(EMAIL_ADDRESS).empty() ||
I feel like this should be covered in one of the other 2 checks in this
condition.

https://codereview.chromium.org/23579009/diff/6001/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2460: // just
ignore email and phone number variants.
:/

[Ilya Sherman, 2013-09-06 04:16:05]

+aruslan for Android changes

Evan, mind taking another look at this CL?  There were some non-trivial changes
introduced while fixing up the unit tests.

https://chromiumcodereview.appspot.com/23579009/diff/6001/chrome/browser/ui/a...
File chrome/browser/ui/autofill/autofill_dialog_common.cc (right):

https://chromiumcodereview.appspot.com/23579009/diff/6001/chrome/browser/ui/a...
chrome/browser/ui/autofill/autofill_dialog_common.cc:133:
arraysize(kBillingInputs) - 1,  // Skip the email field.
On 2013/09/05 16:54:09, Evan Stade wrote:
> hmmm, maybe it would be cleaner to add the email in the SECTION_BILLING case
> rather than removing it in the CC_BILLING case

Done.

https://chromiumcodereview.appspot.com/23579009/diff/6001/chrome/browser/ui/a...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://chromiumcodereview.appspot.com/23579009/diff/6001/chrome/browser/ui/a...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1371: }
On 2013/09/05 16:54:09, Evan Stade wrote:
> DCHECK_EQ(SECTION_BILLING, section)?

Done.

https://chromiumcodereview.appspot.com/23579009/diff/6001/chrome/browser/ui/a...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2454:
profiles[i]->GetRawInfo(EMAIL_ADDRESS).empty() ||
On 2013/09/05 16:54:09, Evan Stade wrote:
> I feel like this should be covered in one of the other 2 checks in this
> condition.

Moved to only affect the billing section.

https://chromiumcodereview.appspot.com/23579009/diff/6001/chrome/browser/ui/a...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2460: // just
ignore email and phone number variants.
On 2013/09/05 16:54:09, Evan Stade wrote:
> :/

I dunno, are email addresses more important than phone numbers when it comes to
variants?  It's a shame to drop them, but it seems like we ought to handle both
equally.

[Evan Stade, 2013-09-06 21:41:00]

still lgtm

https://chromiumcodereview.appspot.com/23579009/diff/6001/chrome/browser/ui/a...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://chromiumcodereview.appspot.com/23579009/diff/6001/chrome/browser/ui/a...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2460: // just
ignore email and phone number variants.
On 2013/09/06 04:16:05, Ilya Sherman wrote:
> On 2013/09/05 16:54:09, Evan Stade wrote:
> > :/
> 
> I dunno, are email addresses more important than phone numbers when it comes
to
> variants?  It's a shame to drop them, but it seems like we ought to handle
both
> equally.

I'd rather not drop either, but only dropping one is superior to dropping  both.
I don't have a better idea though.

[aruslan, 2013-09-06 22:43:35]

android/ lgtm -- what should I look for when testing aside of making sure we get
a "correct" email in Wallet and Autofill modes?

[Ilya Sherman, 2013-09-06 23:06:23]

On 2013/09/06 22:43:35, aruslan wrote:
> android/ lgtm -- what should I look for when testing aside of making sure we
get
> a "correct" email in Wallet and Autofill modes?

In Autofill mode, the email address should be under the "billing" section, both
when entering a new address and when previewing (the summarized form of) an
existing address.  In Wallet mode, there are no expected changes from this CL.

[commit-bot: I haz the power, 2013-09-06 23:06:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/23579009/14001

[commit-bot: I haz the power, 2013-09-07 00:25:31]

Retried try job too often on mac_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-09-07 01:11:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/23579009/50001

[commit-bot: I haz the power, 2013-09-07 07:26:30]

Change committed as 221912