Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3591)

Unified Diff: chrome/common/metrics/variations/variations_util.h

Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review++ Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/metrics/variations/variations_util.h
diff --git a/chrome/common/metrics/variations/variations_util.h b/chrome/common/metrics/variations/variations_util.h
index d32cae7a823f0e013ed825b581760f4129fa8bef..4d5e3fbaa4af6cac44333cbdf95a5eed3e388c55 100644
--- a/chrome/common/metrics/variations/variations_util.h
+++ b/chrome/common/metrics/variations/variations_util.h
@@ -31,24 +31,6 @@ void GetFieldTrialActiveGroupIdsAsStrings(std::vector<std::string>* output);
// them to the child process logging module so it can save it for crash dumps.
void SetChildProcessLoggingVariationList();
-// Takes the list of active groups and builds the label for the ones that have
-// Google Update VariationID associated with them. This will return an empty
-// string if there are no such groups.
-string16 BuildGoogleUpdateExperimentLabel(
- const base::FieldTrial::ActiveGroups& active_groups);
-
-// Creates a final combined experiment labels string with |variation_labels|
-// and |other_labels|, appropriately appending a separator based on their
-// contents. It is assumed that |variation_labels| and |other_labels| do not
-// have leading or trailing separators.
-string16 CombineExperimentLabels(const string16& variation_labels,
- const string16& other_labels);
-
-// Takes the value of experiment_labels from the registry and returns a valid
-// experiment_labels string value containing only the labels that are not
-// associated with Chrome Variations.
-string16 ExtractNonVariationLabels(const string16& labels);
-
// Expose some functions for testing. These functions just wrap functionality
// that is implemented above.
namespace testing {

Powered by Google App Engine
This is Rietveld 408576698