chrome/installer/gcapi/gcapi_registry_overriding_test.h - Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/gcapi/gcapi_registry_overriding_test.h

Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move Windows only variations_util code to variations_util_win Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/installer/gcapi/gcapi_omaha_experiment.cc ('K') | « chrome/installer/gcapi/gcapi_reactivation_test.cc ('k') | chrome/installer/gcapi/gcapi_registry_overriding_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_GCAPI_GCAPI_REGISTRY_OVERRIDING_TEST_H_

	6 #define CHROME_INSTALLER_GCAPI_GCAPI_REGISTRY_OVERRIDING_TEST_H_

	7

	8 #include "base/compiler_specific.h"

	9 #include "base/test/test_reg_util_win.h"

	10 #include "testing/gtest/include/gtest/gtest.h"

	11

	12 // A test fixture for GCAPI tests overriding the registry.

	13 class GCAPIRegistryOverridingTest : public ::testing::Test {
	Alexei Svitkine (slow) 2013/09/03 15:46:35 Instead of exposing a test base class for this, co Instead of exposing a test base class for this, consider just wrapping the functionality into its own non-test class - e.g. GCAPIRegistryOverrideManager that holds the registry_util::RegistryOverrideManager instance and having the Setup() stuff be done in its ctor. Then, any test class that needs this can just add an instance of GCAPIRegistryOverrideManager as a member variable. With that approach, if another test (that has its own test baseclass) also wants to override the GCAPI registry stuff, it can still do it (vs. this design where it wouldn't be able to since it already has its own base class). gab 2013/11/05 22:20:38 Done. Show quoted text On 2013/09/03 15:46:35, Alexei Svitkine wrote: > Instead of exposing a test base class for this, consider just wrapping the > functionality into its own non-test class - e.g. GCAPIRegistryOverrideManager > that holds the registry_util::RegistryOverrideManager instance and having the > Setup() stuff be done in its ctor. > > Then, any test class that needs this can just add an instance of > GCAPIRegistryOverrideManager as a member variable. With that approach, if > another test (that has its own test baseclass) also wants to override the GCAPI > registry stuff, it can still do it (vs. this design where it wouldn't be able to > since it already has its own base class). Done.
	14 protected:

	15 void SetUp() OVERRIDE;
	Alexei Svitkine (slow) 2013/09/03 15:46:35 Declare ctor and destructor explicitly and define Declare ctor and destructor explicitly and define them in the cc file. gab 2013/11/05 22:20:38 Done. Show quoted text On 2013/09/03 15:46:35, Alexei Svitkine wrote: > Declare ctor and destructor explicitly and define them in the cc file. Done.
	16

	17 private:

	18 registry_util::RegistryOverrideManager override_manager_;

	19 };
	Alexei Svitkine (slow) 2013/09/03 15:46:35 DISALLOW_COPY_AND_ASSIGN? DISALLOW_COPY_AND_ASSIGN? gab 2013/11/05 22:20:38 Done. Show quoted text On 2013/09/03 15:46:35, Alexei Svitkine wrote: > DISALLOW_COPY_AND_ASSIGN? Done.
	20

	21 #endif // CHROME_INSTALLER_GCAPI_GCAPI_REGISTRY_OVERRIDING_TEST_H_

OLD	NEW