Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/common/metrics/variations/variations_util.h

Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move Windows only variations_util code to variations_util_win Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_METRICS_VARIATIONS_VARIATIONS_UTIL_H_ 5 #ifndef CHROME_COMMON_METRICS_VARIATIONS_VARIATIONS_UTIL_H_
6 #define CHROME_COMMON_METRICS_VARIATIONS_VARIATIONS_UTIL_H_ 6 #define CHROME_COMMON_METRICS_VARIATIONS_VARIATIONS_UTIL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 17 matching lines...) Expand all
28 28
29 // Generates variation chunks from |variation_strings| that are suitable for 29 // Generates variation chunks from |variation_strings| that are suitable for
30 // crash reporting. 30 // crash reporting.
31 void GenerateVariationChunks(const std::vector<string16>& variation_strings, 31 void GenerateVariationChunks(const std::vector<string16>& variation_strings,
32 std::vector<string16>* chunks); 32 std::vector<string16>* chunks);
33 33
34 // Get the current set of chosen FieldTrial groups (aka variations) and send 34 // Get the current set of chosen FieldTrial groups (aka variations) and send
35 // them to the child process logging module so it can save it for crash dumps. 35 // them to the child process logging module so it can save it for crash dumps.
36 void SetChildProcessLoggingVariationList(); 36 void SetChildProcessLoggingVariationList();
37 37
38 // Takes the list of active groups and builds the label for the ones that have
39 // Google Update VariationID associated with them. This will return an empty
40 // string if there are no such groups.
41 string16 BuildGoogleUpdateExperimentLabel(
42 const base::FieldTrial::ActiveGroups& active_groups);
43
44 // Creates a final combined experiment labels string with |variation_labels|
45 // and |other_labels|, appropriately appending a separator based on their
46 // contents. It is assumed that |variation_labels| and |other_labels| do not
47 // have leading or trailing separators.
48 string16 CombineExperimentLabels(const string16& variation_labels,
49 const string16& other_labels);
50
51 // Takes the value of experiment_labels from the registry and returns a valid
52 // experiment_labels string value containing only the labels that are not
53 // associated with Chrome Variations.
54 string16 ExtractNonVariationLabels(const string16& labels);
55
56 // Expose some functions for testing. These functions just wrap functionality 38 // Expose some functions for testing. These functions just wrap functionality
57 // that is implemented above. 39 // that is implemented above.
58 namespace testing { 40 namespace testing {
59 41
60 // Clears all of the mapped associations. 42 // Clears all of the mapped associations.
61 void ClearAllVariationIDs(); 43 void ClearAllVariationIDs();
62 44
63 void TestGetFieldTrialActiveGroupIds( 45 void TestGetFieldTrialActiveGroupIds(
64 const base::FieldTrial::ActiveGroups& active_groups, 46 const base::FieldTrial::ActiveGroups& active_groups,
65 std::vector<ActiveGroupId>* name_group_ids); 47 std::vector<ActiveGroupId>* name_group_ids);
66 48
67 } // namespace testing 49 } // namespace testing
68 50
69 } // namespace chrome_variations 51 } // namespace chrome_variations
70 52
71 #endif // CHROME_COMMON_METRICS_VARIATIONS_VARIATIONS_UTIL_H_ 53 #endif // CHROME_COMMON_METRICS_VARIATIONS_VARIATIONS_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698