chrome/installer/util/google_update_experiment_util.h - Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/google_update_experiment_util.h

Issue 23579003: GCAPI should append to the existing experiment_labels instead of clobbering them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/installer/gcapi/gcapi_reactivation_test.cc ('K') | « chrome/installer/util/google_update_constants.cc ('k') | chrome/installer/util/google_update_experiment_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_	5 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_

6 #define CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_	6 #define CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_

7	7

8 #include "base/strings/string16.h"	8 #include "base/strings/string16.h"

9	9

	10 namespace base{
	Alexei Svitkine (slow) 2013/11/05 23:05:23 Nit: space before { Nit: space before { gab 2013/11/06 16:39:10 Interesting that presubmit didn't catch that... Do Show quoted text On 2013/11/05 23:05:23, Alexei Svitkine wrote: > Nit: space before { Interesting that presubmit didn't catch that... Done.
	11 class Time;

	12 }

	13

10 namespace installer {	14 namespace installer {

11	15

12 // Constructs a date string in the format understood by Google Update for the	16 // Constructs a date string in the format understood by Google Update for the

13 // current time plus one year.	17 // \|current_time\| plus one year.

14 string16 BuildExperimentDateString();	18 string16 BuildExperimentDateString(const base::Time& current_time);

15	19

16 } // namespace installer	20 } // namespace installer

17	21

18 #endif // CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_	22 #endif // CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_

OLD	NEW